[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 3/7] xen/arm: Rework psr_mode_is_32bit()
- To: Julien Grall <julien.grall@xxxxxxx>
- From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Date: Fri, 26 Jul 2019 14:05:54 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=epam.com;dmarc=pass action=none header.from=epam.com;dkim=pass header.d=epam.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O93MJu5U+Nim32bDVEwhMQNG+iWHugbtSSi7/zzfNiA=; b=YwJgEkSIZ1gAJw+8vGCPdYX5Mwx/nwQqG3VXQCmRuyiT4Y6N3tsV5v62vbWRAZeSyTWg41rjXkuhR9Usz4U8sWZFoDDCzCvRHUr+zEai6500ZToJ3pfLGYgtgHznUoY7XvUTKNhfPanrE/gbMlZaQXVo7THUSq4hqtzAOo+gO7Gnw0wSVNeZ8Q74sd1vgx/FzmWsFGMw4ych4orTb6j6B8gkppLw4HMst2YpZFZdD5G7iZ5402DXOe7vmkfsLnAmK7LMwMGSzJ6jU0GuqbmgdFNnsh+RgwT0tE20AkKyKPceIH9CXQAZXtm0v2VjtgmB0fyhrTTqnAsKx0NdWaLIRg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c1wpE23eeDyKFCaRwXTgIIt42gUG7YFK9OqVla258wx7vRhcFbh45LRAurWB5KVSn9W8JlvFswOj+OE0mg38tQKzmdOZjFSJ2wMVWm9Q4ykKh4OAmcUCvdnH5SgWGyyE7NU4SMeUBOhAIhsM6IwzJdMt3AQttFxnUEfH4yuiMfcm0OTjCeXpADhbYzd2v3L2bwEY8PdkpmYjc5AH3ySRilytL6GuEa54ZmRcHu63qhfNELU6bxGXZtnK3a7u5XjTWq2Jd6RQh6Z2um9hvo4jTQg7uE118ykFZx1k22/+fSbJueVmHg2ABT/vrp9iKaRUNTTEHbj6ozLc2cdjVeL1Dw==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Volodymyr_Babchuk@xxxxxxxx;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 26 Jul 2019 14:05:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVQZ6ijXP3wTXU302IoyTKXwcds6bc2NmAgAAKkQCAAA/SAA==
- Thread-topic: [PATCH 3/7] xen/arm: Rework psr_mode_is_32bit()
Julien Grall writes:
> Hi,
>
> On 26/07/2019 13:31, Volodymyr Babchuk wrote:
>>
>> Julien Grall writes:
>>
>>> psr_mode_is_32bit() prototype does not match the rest of the helpers for
>>> the process state. Looking at the callers, most of them will access
>>> struct cpu_user_regs just for calling psr_mode_is_32bit().
>>>
>>> The macro is now reworked to take a struct cpu_user_regs in parameter.
>>> At the same time take the opportunity to switch to a static inline
>>> helper.
>> I'm a bit concerned about naming now. As psr_mode_is_32bit() is now have
>> no psr parameter, and ARM ARM uses term "state" instead of "mode", maybe
>> it is worth to rename this helper to something like "is_32bit_state"?
>
> It really depends how you see it. The bit is part of the "mode" field,
> so technically we are checking whether the mode corresponds to a
> 32-bit one or not. This is also inline with the rest of the helpers
> within this header.
>
> I would be willing to consider renaming the helper to regs_mode_is_32bit().
I'm fine with this name.
--
Volodymyr Babchuk at EPAM
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
