[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 01/35] xen/arm64: macros: Introduce an assembly macro to alias x30


  • To: Julien Grall <julien.grall@xxxxxxx>
  • From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Date: Fri, 26 Jul 2019 14:28:05 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=epam.com;dmarc=pass action=none header.from=epam.com;dkim=pass header.d=epam.com;arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BGG5xNZfcThoeZvm5Sm8eDSyEflhaFJJeYzIZNUj1nw=; b=JDJo5pCKuuwuEHsy9j5tqVoWrCHsO5BY/6HRJqhJ+O14QDIrD1h1KWccbEOhwOIOCsL3kXo222pNniu+UkVYG24Afhi3bbqdRdgEtwhrLHOYAM/Cgwp4vsULfNwIKQM44e6qmp6UC0LsQlpaNXUMrunahKLAfpBbGKGFFMo3oGS1su4tdf42ENBQ0b0tetzSCkUxZLo4YxbVTQ9T5JevweuTPfV4n8DaYcwGFx4IxRqAqi/CjLZ41xGD0yff1iuMcEOjfxyFQrTo1aTKjf57P26EgqPO0ZBHYV9tg2fq73soiNyGvGCRMpB7At2VEjAvotGK33TydaKPbg+tBqyD2w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V3SVA0nNmP6uFgguitz3z3gsTe7c3VqVqFqGy6v5XZVXPe/s+Ssn/QrHAtj5VbR2BmtM+3Owm5W15gK5eHSzlmc1pS38Ob1xpf1e9EZwsXY0zdAC2/s7ENqtSrlhH8klPTEDHLaKp+q8fj74PDxCogVDt5mJOxai8BmXfr/Kz4uekdFjR1AKryGVkroEqnuyUfAxVv5fZzUztGPn+GuS1f+Ecs8ACiwcMo+bbiKTTQmbnn9+kosrLJM2jL785N5l7Fei6pcBw0V7jATTnRK9MuMOwZgkeMLctObADBEukuBZ50srCS6Pn21E2VM2ZetevyUWQjQevQCAND5Vh0bbZw==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Volodymyr_Babchuk@xxxxxxxx;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Fri, 26 Jul 2019 14:28:10 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVQNYJDI/OfN/Uj0qAC6V0n+ChE6bc+v8A
  • Thread-topic: [PATCH v2 01/35] xen/arm64: macros: Introduce an assembly macro to alias x30


Julien Grall writes:

> The return address of a function is always stored in x30. For convenience,
> introduce a register alias so "lr" can be used in assembly.
>
> This is defined in asm-arm/arm64/macros.h to allow all assembly files
> to use it.
>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>

>
> ---
>     Changes in v2:
>         - Patch added
> ---
>  xen/arch/arm/arm64/entry.S         | 5 -----
>  xen/include/asm-arm/arm64/macros.h | 5 +++++
>  2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S
> index 97b05f53ea..2d9a2713a1 100644
> --- a/xen/arch/arm/arm64/entry.S
> +++ b/xen/arch/arm/arm64/entry.S
> @@ -7,11 +7,6 @@
>  #include <public/xen.h>
>  
>  /*
> - * Register aliases.
> - */
> -lr      .req    x30             /* link register */
> -
> -/*
>   * Stack pushing/popping (register pairs only). Equivalent to store decrement
>   * before, load increment after.
>   */
> diff --git a/xen/include/asm-arm/arm64/macros.h 
> b/xen/include/asm-arm/arm64/macros.h
> index 9c5e676b37..f981b4f43e 100644
> --- a/xen/include/asm-arm/arm64/macros.h
> +++ b/xen/include/asm-arm/arm64/macros.h
> @@ -21,5 +21,10 @@
>      ldr     \dst, [\dst, \tmp]
>      .endm
>  
> +/*
> + * Register aliases.
> + */
> +lr      .req    x30             /* link register */
> +
>  #endif /* __ASM_ARM_ARM64_MACROS_H */


-- 
Volodymyr Babchuk at EPAM
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.