Re: [Xen-devel] [RFC] xen: Add .astylerc for automated style-formatting

[Tamas K Lengyel <tamas@xxxxxxxxxxxxx>]

On Fri, Jul 26, 2019 at 8:42 AM Viktor Mitin <viktor.mitin.19@xxxxxxxxx> wrote:
>
> Hi All,
>
> On Thu, Jul 18, 2019 at 6:16 PM Jan Beulich <JBeulich@xxxxxxxx> wrote:
> >
> > On 18.07.2019 16:43, Tamas K Lengyel wrote:
> > > --- a/CODING_STYLE
> > > +++ b/CODING_STYLE
> > > @@ -60,8 +60,8 @@ Bracing
> > >   -------
> > >
> > >   Braces ('{' and '}') are usually placed on a line of their own, except
> > > -for the do/while loop.  This is unlike the Linux coding style and
> > > -unlike K&R.  do/while loops are an exception. e.g.:
> > > +for the while-part of do/while loops.  This is unlike the Linux coding 
> > > style
> > > +and unlike K&R.  do/while loops are an exception. e.g.:
> > >
> > >   if ( condition )
> > >   {
> > > @@ -77,7 +77,8 @@ while ( condition )
> > >       /* Do stuff. */
> > >   }
> > >
> > > -do {
> > > +do
> > > +{
> > >       /* Do stuff. */
> > >   } while ( condition );
> >
> > I disagree with this change: There's a large number of (correct as
> > per the text prior to your change) instances, and since there's
> > nothing affecting the length of such lines avoiding the extra line
> > is quite desirable imo.
> >
>
> Please be aware that 'xen modified' clang-format supports such
> 'do/while' braces exception.
> It has been tested previously and works well.
>

Sounds good to me, I would say let's go with that if it reduces churn
in the code.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel