Re: [Xen-devel] [PATCH V2] tools/libxl: Add iothread support for COLO

["Zhang, Chen" <chen.zhang@xxxxxxxxx>]

> -----Original Message-----
> From: Anthony PERARD [mailto:anthony.perard@xxxxxxxxxx]
> Sent: Friday, July 26, 2019 10:34 PM
> To: Zhang, Chen <chen.zhang@xxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx; Zhang Chen <zhangckid@xxxxxxxxx>
> Subject: Re: [PATCH V2] tools/libxl: Add iothread support for COLO
> 
> On Fri, Jul 26, 2019 at 02:18:42PM +0000, Zhang, Chen wrote:
> >
> > > -----Original Message-----
> > > From: Anthony PERARD [mailto:anthony.perard@xxxxxxxxxx]
> > > Sent: Friday, July 26, 2019 9:48 PM
> > >
> > > On Fri, Jul 26, 2019 at 02:43:00PM +0800, Zhang Chen wrote:
> > > What I had in mind while reviewing the v1 of the patch was to remove
> > > both `colo_iothread' and `colo_compare_iothread' from the libxl API
> > > and xl config option. I don't think there are useful. Why did you keep
> `colo_iothread'?
> >
> > Oh, it looks I misunderstood your means.
> > Do you think we just need hard code the iothread name here?
> > For example the "iothread-1"?
> 
> Yes, it would be better to hard code for now, but with a name which better
> describe where the iothread is used, how about "colo-compare-iothread-1" ?
> 

It is fine for me.
Thanks your comments.

Thanks
Zhang Chen

> Thanks,
> 
> --
> Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel