[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC] xen: Add .astylerc for automated style-formatting





On 26/07/2019 16:48, Viktor Mitin wrote:
Hi All,

On Thu, Jul 18, 2019 at 5:45 PM Tamas K Lengyel <tamas@xxxxxxxxxxxxx> wrote:

Checking the comment styles are not included in the automation.

The same about clang-format. Checking the comment styles is not supported.
It seems this is not code format checker task to parse and modify the
code comments...

Are you sure about your statement? Looking at the diff you provided [1], clang-format is clearly trying to alter the comments.

But comments flow are equally important as the code. This is part of the coding style afterall.

[1] https://raw.githubusercontent.com/viktor-mitin/xen-clang-format-example/master/0001-clang-format-checkpatch-output-example.patch


Thanks


--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.