[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 4/4] xen/percpu: Make DECLARE_PER_CPU() and __DEFINE_PER_CPU() common
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Mon, 29 Jul 2019 13:00:32 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JAcvOlVixIpJOznT3Upakt5gxGX8bBKER6/IjZ8kdsI=; b=OBOmB2Frg+88GwP18P4TYs2DCAX+aKP6l0+rtC4K3hBRD/IFA7A452+aSYjl81S4s+YuJYMBsE+bIXsApChMhEqA0zTcONWIBCYlowHyJGVAt68T0p0sZbnbKd5ooZhQuXX0R9Ajj11zAM4aVgF6X15Yb9PLZYGmu+ztU9jFkSg1kloROa7/bBWWRwsI7fFC2abavekEW/JiEH68/6JD0gqWpQaCMrvHAndjAcksUVDkFEGoViMncvidb2n6D7j/cqB+yWgZRcCX7Y9Yyy5ltWiS4sdjICWxnIhJmkLcdCz7y90mPKj2Q5vdeH7L2heaKuOLG6+fY2GPxp0KogbsPQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AMb5+MIWmP27NgATKK9zLLkbRK+gnOBNOd90g8gqh5uTu/xZTHKOduJNA5sl+AJuQ49dJpFEktrifFJZgOoLnVgVf3t9HaF1yXZWFM6HOzN+FQ2xDglRNQr+bLm/rPQz3TM8UcfofPENYfSNiWyVQ+ABOwhIVIl97qpxPi+B3acfHMIDoKGWkzA2Yvo9pXt0AQ72oFsfo4Q0ND3B58js2muC51GXlotxlmwfPPOqjlELJI/azsLkUCvC7CVW3col9YuplP34jxPzGafBLYjffPAVDnZEatrANm1aNQSHwaWCtbZqHHpH7iFOM4Ap6Labj1eoWF9v57F6uaTe5soysQ==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: StefanoStabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 29 Jul 2019 13:20:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVQ/aLJfmONJuXtEOXa2NkIvPAfabhkz+A
- Thread-topic: [PATCH 4/4] xen/percpu: Make DECLARE_PER_CPU() and __DEFINE_PER_CPU() common
On 26.07.2019 23:08, Andrew Cooper wrote:
> --- a/xen/include/xen/percpu.h
> +++ b/xen/include/xen/percpu.h
> @@ -3,6 +3,12 @@
>
> #include <asm/percpu.h>
>
> +#define DECLARE_PER_CPU(type, name) \
> + extern __typeof__(type) per_cpu__ ## name
> +
> +#define __DEFINE_PER_CPU(attr, type, name) \
> + attr __typeof__(type) per_cpu_ ## name
> +
> /*
> * Separate out the type, so (int[3], foo) works.
> *
By moving things here you render stale the remainder of the
comment in context above: No per-arch symbol name prefix is going
to be possible anymore. I'm not against it, but this comment
would then want adjusting. What's not immediately clear to me is
whether the two-stage concatenation of an underscore each is then
still necessary.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
