[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 1/3] kconfig: include default toolchain values
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Mon, 29 Jul 2019 15:31:31 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DYpeD9xDfIS5Ebj/FRqdWldXFfZ4i9dS3x7nW1MZs5g=; b=daVUjzoQDQ8kccPR2RKAgoDpyAdz/9vjkQD7IKbhxn6EyEAgcNpuMwEzB8LNX8Kb7odEe95fmKM188Y+1kb/wXP+ifX0OFIegJlpepy90fFsCwuGA5VpCaWGILV9MFYZ6z1bD3LurBUoOCiTa8yDI0YUtRkXw38OugM2lB2saNXkgEnnwRDHjl+ZAZKTJUybUa+7uYOsnEYI/6MPSvDVSy/0WNa8iYFHUbzXkZQox3ZFDSYJwv1NqVhCMM+FBIaZDscn5nn0ijEh3SfsN5x2+IbJOw0JmFPioK8zR/5jzEP2gqG5NZUQZ3xdZQADzNz0nlDH2hEK96mY9yYj8NY2xw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZFYgsyCNY7mctMErOE0t3NLV777QHzCRgwtLwRM9SWBa+Jk9WXHNZrV5B4OoeJ82eskjpUAaG7Pn9sBrFIGNadAqCLxKji5cnS8WPKvR+hajtdoWWhNljYHnlOG+fPp18ytYElyiPRqtRJu3E+TrNoU1RT7OrHNsEo7ieWyoFkv3m+mo6mDcqyrZu6pWkpVCrYdMfLKeLIWkEJG1VU4BcCYp0oX6zK6Ye+2UZeG6AQNibBdIe/MiIK0t5Nt/y4rGUOWFePdglSckky8v6EMk5ecpDXjpx4zW/ExUkknN20m2FCwOpyL3YhgWlJGVK+S1WC5w4b/Jtwxt62smQ7NBuQ==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, TimDeegan <tim@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 29 Jul 2019 15:51:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVQ7bZ4JfBDdQhHkSeEuJQATAI7abhve2A
- Thread-topic: [PATCH 1/3] kconfig: include default toolchain values
On 26.07.2019 15:33, Roger Pau Monne wrote:
> Include config/$(OS).mk which contains the default values for the
> toolchain variables. This removes the need to pass HOST{CC/CXX} as
> parameters from the high level make target or to default them to
> gcc/g++ if unset.
From this description I thought reviewing would be straightforward.
However, ...
> --- a/xen/tools/kconfig/Makefile.kconfig
> +++ b/xen/tools/kconfig/Makefile.kconfig
> @@ -35,15 +35,14 @@ KBUILD_DEFCONFIG := $(ARCH)_defconfig
> # provide our shell
> CONFIG_SHELL := $(SHELL)
>
> -# provide the host compiler
> -HOSTCC ?= gcc
> -HOSTCXX ?= g++
> -
> # force target
> PHONY += FORCE
>
> FORCE:
>
> +# Sets toolchain binaries to use
> +include $(XEN_ROOT)/config/$(shell uname -s).mk
> +
> # include the original Makefile and Makefile.host from Linux
> include $(src)/Makefile
> include $(src)/Makefile.host
... neither the make file here nor the two ones included (in
context above) include any other file (afaics) that would lead to
HOSTCC being defined. And nothing under $(XEN_ROOT)/config/ looks
to define it either. I guess I'm missing something, as I'm sure
this is working for you.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
