[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 2/3] build: allow picking the env values for compiler variables
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Mon, 29 Jul 2019 15:35:36 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3M+rgRFCGKg8h1Zmb2VnvD6B7ep5g1ycz2uC/A4wQtA=; b=mHe9isnImhapekUv98HGIz/WEfkldIWrNlnkhc0q7AM8LBbncQeSUFibkftbD/iSI0OXFBUwWzvMJKK/iZjG3TNqq7+WqJFicpENsV9ZiApFsNFC/IDH4iuBeBCT3pLlN+cMaSrJBreuTv94RoJo4zfWsOiwID8Oidv8FaV0XyhNvhKrKTZsa8MNM8ayDv9HoJX6xlNh/gIjG0lchPQi9P4nQqPB+iJ3gR6uS1GSpGhxXWUKlnwdboWkbsYEgqAHGS66TkhrMC55p3R0GhmWsZlUF9p75LxpF9lM8f5CtOJQyO+8B1xYQo3AmAOmfo+688/SN2vnqft6tb0IB6/jvg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JvPcBz6VGH3jv6n9+ldiotyRFegCl6yff5LN+B9EIkugtii8LNOswR6YjdqveMSWzVjAVmbcDDSkC/A0VK8KefD05waKsLHB1FXqA4InBANAwvOLSX3JxMoBpjnby4x53sIsIcg6vtO6YNucFGtNkiWdAzgC+9lQhuGTZxUYtmdEerZyrfTxwW1OSsacpg39hmPWA7xC5oEGQdOp0nvUDOY9MwmxVjH2iTdi9Jh8/Yjx6ANwpzUeQXiaLhIHEwclY2NI+YQ+ozx8OTN2Xs/3JG6VA2YZUc3L4exLPD8Q8G8uWQkg3qjXUC/LK6fPtsriGovN0TMucSi9cX6CTCs9HQ==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, TimDeegan <tim@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 29 Jul 2019 15:55:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVQ7bRDE0fGAhFDE++tH3QzKoz3abhvxKA
- Thread-topic: [PATCH 2/3] build: allow picking the env values for compiler variables
On 26.07.2019 15:33, Roger Pau Monne wrote:
> Don't force the usage of the hardcoded compiler values if those are
> already set on the environment. This allows the Xen build system to
> correctly pick CC/CXX values present on the environment, and fixes the
> usage of those by the Gitlab CI test system.
>
> Note that without this fix the Xen build system will completely ignore
> any CC or CXX values set on the environment, and the only way to pass
> a different CC or CXX is to overwrite it on the make command line.
Now the question is: Do we possibly want it to be that way? I've always
been of the opinion that inheriting something that happens to be (left?)
set in the environment is not a good idea. Hence I've been welcoming all
changes that removed dependencies on settings possibly coming from the
environment. (Exceptions of course are XEN_* environment variables we
specifically evaluate.)
As a result I'm inclined to nak this patch, but I'm open to arguments.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
