[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] xen/arm: irq: Don't use _IRQ_PENDING when handling host interrupt



On Mon, 10 Jun 2019, Julien Grall wrote:
> On 6/10/19 12:23 PM, Andrii Anisov wrote:
> > Hello Julien,
> 
> Hi,
> 
> > On 02.06.19 13:26, Julien Grall wrote:
> > 
> > > + * This should only be called with interrupt routed to guest. The flow
> > > + * of interrupt routed to Xen any software change of the state.
> > 
> > Sorry I can't parse the last sentence. It seems to me you missed a
> > word/words?
> 
> Hmmm, sorry for that. How about the following:
> 
> "This should only be called with interrupt routed to guest. The flow of
> interrupt routed to Xen is not able cope with software change of the active
> state"?
> 
> > 
> > For the rest:
> > 
> > Reviewed-by: Andrii Anisov <andrii_anisov@xxxxxxxx>
> 
> Thank you for the review! I am not planning to resend the patch and I will
> update the comment on commit (pending Stefano's review).

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

I'll update on commit.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.