[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 1/6] domain: stash xen_domctl_createdomain flags in struct domain


  • To: Paul Durrant <paul.durrant@xxxxxxxxxx>
  • From: Jan Beulich <JBeulich@xxxxxxxx>
  • Date: Tue, 30 Jul 2019 09:17:22 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IQSGqpbs1ISNeSc+d49++n04ytQIchLRhUbiraBhkBY=; b=NafAdPDJ7ttDlWnDqUgY9KabvvTShBATMSp3gjmV3k/ZRSRXAb81PaBL6ioYSdLroYOx0Iycbp8EGWFEo8KAwWhsX5wjkFtj2utDQCAND7O2z+gas/w+dr8HyuMzGorcWKtCPki55E5JemXYBx40zZWZMjul+eBl3E1JMV1ncLqkPI97j+yAN1d57s4Zcz7/5FWxsYdUOo6Rq+qFd4nvlMoVgT3Ar75UfWzSbLVPnoxrp+F/WCTp1AICsxuIBY2Hy9OZVXwlZOdfvNyvUZ91FQ+GvD+yCRTsKEb9AptREwCbdO+z053Iri3G+Y/INUt3QC7wciFtQ4RjOXbjeaE1nw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EbLdGruUKJKo72BekdE8SUHtW5nxXc0AdwCsEEamJCm3AyVkTsV1v0pwmekYfma3qXq4n14afJDRmCOmyzmeJmk0DrCbl1YAGLARUyDtfn9A94GD6jeIU/YuNFisYja1OXiSS7uy6q9vRU3z32hxRPZMptzt/djXwVQn+85YglF4hMVdPn6Wt2W8fwOraqg5T4f8/cpP3lFm8LyxRDXosf3rHff+KHi0r7RUeoDvI7zXSPSqLedZafdAdWX219+aTE6TheIwadKUGi8ewAPI8Tg/SdJ0iahVMcAi9X2D9ehVEBTq8+UNcO+dWx8P5qXvBwRoFGkxH7cOC7yjztMz4A==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 30 Jul 2019 09:22:17 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVQu6akvnjr7AS1UCxO+8m8M4Duqbi6UsA
  • Thread-topic: [Xen-devel] [PATCH v2 1/6] domain: stash xen_domctl_createdomain flags in struct domain

On 25.07.2019 15:39, Paul Durrant wrote:
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -306,6 +306,7 @@ enum guest_type {
>   
>   struct domain
>   {
> +    unsigned int     options;         /* copy of createdomain flags */
>      domid_t          domain_id;
>   
>      unsigned int     max_vcpus;

I was about to commit this when I noticed the placement here:
I think it would be pretty good to retain domain_id as the
first field. I'll be happy to make that adjustment while
committing, as long as you are fine with me doing so.

Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.