[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Intel TXT: add reviewer, move to Odd Fixes state



Hi Jan,

On 30/07/2019 10:05, Jan Beulich wrote:
On 30.07.2019 10:54, Julien Grall wrote:
On 7/30/19 9:29 AM, Jan Beulich wrote:
On 30.07.2019 08:56, Lukasz Hawrylko wrote:
Support for Intel TXT has orphaned status right now because
no active maintainter is listed. Adding myself as reviewer
and moving it to Odd Fixes state.

Signed-off-by: Lukasz Hawrylko <lukasz.hawrylko@xxxxxxxxx>
---
    MAINTAINERS | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 89a01b710b..ca300e87c8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -240,7 +240,8 @@ S:    Maintained
  F:    tools/golang
  INTEL(R) TRUSTED EXECUTION TECHNOLOGY (TXT)
-S:    Orphaned
+R:    Lukasz Hawrylko <lukasz.hawrylko@xxxxxxxxx>
+S:    Odd Fixes

I guess we should give it a few days for objections to be raised
against this slightly inconsistent state, but I think that's the
best way to express the current state of things (hence my
suggestion to this effect). If no objections turn up, I've queued
this onto my to-be-committed list.

I have some objections regarding the process itself... On the first
version of this patch, it was pointed out that the e-mail shouldn't
be sent with disclaimer. This is now the third version and the
disclaimer is still present.

Okay, I must have missed both earlier requests to this effect. I've
gone back to the list archives though, and I couldn't find any such
request either from July or June. Therefore ...

The first version was sent from March [1].


Technically, no patch should be applied when there are a disclaimer.

... I'd also like to ask for the background of this. It would never
have occurred to me that I should pay attention to possible
disclaimers or alike on patch submissions.

The disclaimer tell you this patch may contain confidential information and you are not allowed to distribute it... While I agree this makes no sense for public ML, we still have to stay on the safe side. How do you know this was not sent by mistake? Note that this question makes little sense on MAINTAINERS file...

In general, I am following Greg KH advice here [2] and refrain to answer any e-mail with disclaimer. I would actually advocate xen-devel to completely block those e-mails.

Cheers,

[1] https://lists.xenproject.org/archives/html/xen-devel/2019-03/msg00729.html
[2] https://www.youtube.com/watch?v=fMeH7wqOwXA&feature=youtu.be&t=13m53s

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.