[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v3 08/10] xen/nodemask: Introduce unlocked __nodemask_{set, clear}() helpers
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Tue, 30 Jul 2019 11:26:37 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PKhcQdi4rYdnSP7CHUtuaTnevhIPu5W0a+389yuvrYY=; b=HfCx01sLTgPthGxz70mSA1hp1/u3MG1dIT1/moBnuq4xxXevs1Gvc1dVDFKMFjQTcudLzScguz87f9Z8xMFQ3F1987hiGcIrrrBBM1Ym+6EV+gHY8rO/lHguEFtVpdtTyj9AY1poJIgYZGKY/JHPeBf3wefwAwptWeX8DQr1bwl07rMmZgbAQ6+VnXKAo/nhQ0JVoNdALQPK+wSCPZIAyZjQU2HoRUqDZl09FqncyWtOw9TFJsYTJhvUuSMIYwcSCyVF6f1Gfh10uXSLpsWoVkqUjFUTwvuLwlPV0H9EqLPd5YBbqKXqTsQ9fuN/WYdSn02fcOyUah8QaZ4YFJImoQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jOPejiiKDmqMyj3l3YBhcko8HSItRVYEfIg62WNa1IkiK0P/Wqn+vrzjw6EtWNigQqdGSW2sc/GpIk0FwR/4aIlFuvng/IALD/dT7sWNMmGFWNRydWK+TC1RalhaELWqcte4rzuDZPExOF6d/uo5Jbvrn3oK3w7Ag/49NRBYrxaAWKknylxIFIOFb4V6MbWYLJRXj6ytNgbD8+PvI6n+6iY5dZU/+U3MU6PZFW6SnHhDL576Q2WiMsu3ghwXUrVSStjXQi23SxKp3Hn1JyeoEL50OpD+RbN+tXYfugZPJjpvbCGHrvyh6eQRh+AGIWcgBXYf8jnVpZ22wQE5jp5z9A==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: StefanoStabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 30 Jul 2019 11:34:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVRgbw7C6GvWJsh0yxbCWlYQa9EqbjBzYA
- Thread-topic: [PATCH v3 08/10] xen/nodemask: Introduce unlocked __nodemask_{set,clear}() helpers
On 29.07.2019 14:12, Andrew Cooper wrote:
> --- a/xen/include/xen/nodemask.h
> +++ b/xen/include/xen/nodemask.h
> @@ -11,7 +11,9 @@
> * The available nodemask operations are:
> *
> * void node_set(node, mask) turn on bit 'node' in mask
> + * void __nodemask_set(node, mask) turn on bit 'node' in mask (unlocked)
> * void node_clear(node, mask) turn off bit 'node' in mask
> + * void __nodemask_clear(node, mask) turn off bit 'node' in mask (unlocked)
To be honest I'm unhappy to see you introduce new name space
violations. I realize you want to have the node mask interfaces
match the CPU mask one as closely as possible, but I think we
should diverge here (and eventually make the CPU mask ones
follow whatever route we go here). As to naming, since these
are static inlines, a single leading underscore may be an
option (albeit I'd prefer to avoid this). Another option would
be to have double infix underscores (nodemask__set()). Yet
another option would be to express the non-atomicity in a
verbal way rather than by the number of underscores used. I'm
afraid I don't have a good naming suggestion in that case,
though.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
