Re: [Xen-devel] [PATCH v4] xen/doc: Improve Dom0-less documentation

[Viktor Mitin <viktor.mitin.19@xxxxxxxxx>]

On Wed, Jul 31, 2019 at 11:40 AM Julien Grall <julien.grall@xxxxxxx> wrote:
>
> Hi,
>
Hi Julien,


> On 7/31/19 9:10 AM, Viktor Mitin wrote:
> > - Changed unprintable characters with %s/\%xA0/ /g
> >    So all the spaces are 0x20 now.
> >
> > - Added address-cells and size-cells to configuration example.
> >    This resolves the dom0less boot issue in case of arm64.
> >
> > - Added some notes about xl tools usage in case of dom0less.
> >
> > Signed-off-by: Viktor Mitin <viktor_mitin@xxxxxxxx>
> > ---
> > v4 updates:
> >     - fixed cpus <1>;
> >     - added memory size note;
> >     - changed some numbers to decimal;
> >
> > ---
> >   docs/features/dom0less.pandoc | 61 ++++++++++++++++++++++++-----------
> >   1 file changed, 42 insertions(+), 19 deletions(-)
> >
> > diff --git a/docs/features/dom0less.pandoc b/docs/features/dom0less.pandoc
> > index e076e3739e..a2c95d1fd4 100644
> > --- a/docs/features/dom0less.pandoc
> > +++ b/docs/features/dom0less.pandoc
> > @@ -40,8 +40,8 @@ to boot. For example if this is the bootcmd for Xen and 
> > Dom0:
> >
> >       bootm 0x1400000 0x9000000 0x1280000
> >
> > -If we want to add one DomU with Image-DomU as the DomU kernel
> > -and ramdisk-DomU as DomU ramdisk:
> > +If we want to add one DomU with Image-DomU as the DomU kernel
> > +and ramdisk-DomU as DomU ramdisk:
> >
> >       tftpb 0x1280000 xen.dtb
> >       tftpb 0x80000 xen-Image
> > @@ -61,27 +61,32 @@ the presence of the additional VM and its 
> > configuration. It is done via
> >   device tree adding a node under /chosen as follows:
> >
> >       domU1 {
> > -        compatible = "xen,domain";
> > -        memory = <0x20000>;
> > -        cpus = 1;
> > -        vpl011;
> > -
> > -        module@2000000 {
> > -            compatible = "multiboot,kernel", "multiboot,module";
> > -            reg = <0x2000000 0xffffff>;
> > -            bootargs = "console=ttyAMA0";
> > -        };
> > -
> > -        module@30000000 {
> > -            compatible = "multiboot,ramdisk", "multiboot,module";
> > -            reg = <0x3000000 0xffffff>;
> > -        };
> > +        #address-cells = <1>;
> > +        #size-cells = <1>;
> > +        compatible = "xen,domain";
> > +        memory = <0 524288>;
>
> For a first, the new value does not match the old one (0x20000 = 131072
> in decimal).
>
> However, this does not makes much sense to describe the memory size in
> decimal here and ...
>
> > +        cpus = <1>;
> > +        vpl011;
> > +
> > +        module@2000000 {
> > +            compatible = "multiboot,kernel", "multiboot,module";
> > +            reg = <0x2000000 0xffffff>;
>
> ... here in hexadecimal. For memory, it is fairly common to use hexadecimal.
>
> I can switch the memory property back to hexadecimal on commit. But I
> would like to understand why the value has changed before doing that.

Ok, let's keep hexadecimal.
128Mb is ok in this example, I use 512Mb for my tests,
so while testing this example I changed it and didn't restore.

This should be left untouched, as you mentioned.
memory = <0x0 0x20000>;

Thanks

>
> Cheers,
>
> --
> Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel