[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] CODING_STYLE: clarify function argument indentation
- To: Lars Kurth <lars.kurth.xen@xxxxxxxxx>
- From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Date: Wed, 31 Jul 2019 17:57:32 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=epam.com;dmarc=pass action=none header.from=epam.com;dkim=pass header.d=epam.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=USb0LlIOSHhMO8610XlnDxQmfkz/doJ18PZsF3anGNc=; b=MQ/UkzUeWkE9xZa6z+lqn2l5nI8PJKKfYBoeuHIgJ17b9VNwdhKFBSWxi/sXv5UIkLxUIWYP8fWACDj7bp4d1hZ75LdNGLkYhxX2IzHKz1KAUmFhqSa3mxfSx7wBJw4euk0t8ejygb4b7FQ2sAuQ7bLO2PsiPpeTtdjJOGfF6vm9IeK6kt9AWyjN035rA/BgBvN25u0CukS+sHEyTQhkRUcFvvZLduiz7ej0vcs5ikZqgPWRf+ogXKbZNL6ue9tjlElgjuOsTDSzRte3xS6Seab1qJALDX8dOlpUnL4AaOtevutsz2CZ5ipjjLQCPb81SseaQsMYXrucDtoCCg7Q6A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lA+dNrcXcrCF6iexTIvS43fws1ofILTcVfFW25thKFtIAMK5GXzvNPwaxGU2cyApso+BfzD+Ws2XG6E1H/rj2Woi2puhHewkxGlPx56dAK9JElY54hW4od7ksD6ASgeWY5R0T09KdZ98lZx4+JBxrZ9eXD/UdtP3AIXxhDDtA55zhVTzcF6JFfpBRYLQt7BMrzWOx7YIzzLxvOd0rllrmIREOZF/DP1Qd2P0tAMofTT+HpfAGmwsaHPFEaTV8RkWcbjtU78Uz/DjnDvOl82q08bFx1qr9hkz38U5gfyGOr6SBPiu0JOm491uFDwBpohlDfWDCwBYzuok8MBRHNqTZg==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Volodymyr_Babchuk@xxxxxxxx;
- Cc: Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, "Tim \(Xen.org\)" <tim@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, 'Jan Beulich' <jbeulich@xxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Viktor Mitin <viktor.mitin.19@xxxxxxxxx>
- Delivery-date: Wed, 31 Jul 2019 17:57:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVR7xxvb8iYZ/UOE68NI2ovvNVU6bk70gAgAACfACAAAMHAIAADpSA
- Thread-topic: [PATCH] CODING_STYLE: clarify function argument indentation
Hi Lars,
Lars Kurth writes:
>> On 31 Jul 2019, at 17:54, Viktor Mitin <viktor.mitin.19@xxxxxxxxx> wrote:
>>
>> Hi All,
>>
>> On Wed, Jul 31, 2019 at 7:45 PM Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> wrote:
>>>
>>> On 31/07/2019 17:24, Volodymyr Babchuk wrote:
[...]
> Ultimately we have to make some trade-offs as to what is more important:
> a) automatic style checking - which means "common sense" can't be formalised
> and there will be boundary cases like the above
> b) reclaiming code review bandwidth through automation or going for a labour
> intensive manual approach
I like the linux kernel approach. checkpatch.pl produces errors, which are
"no go", but it also produces warnings for such boundary cases, for
maintainer/reviewer to decide.
> I suggest we discuss in tomorrow's community call how to approach
> this.
Good idea, I'll attend.
> I think the most important first step is to have a good view on the kind of
> boundary cases that we may face
Then we need some volunteer who'll try to cover all corner cases.
--
Volodymyr Babchuk at EPAM
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
