Re: [Xen-devel] [PATCH v2 22/35] xen/arm32: head: Rework UART initialization on boot CPU

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 7/30/19 8:40 PM, Stefano Stabellini wrote:
> On Mon, 22 Jul 2019, Julien Grall wrote:
> > @@ -497,11 +497,15 @@ ENTRY(switch_ttbr)
> >   
> >   #ifdef CONFIG_EARLY_PRINTK
> >   /*
> > - * Bring up the UART.
> > - * r11: Early UART base address
> > - * Clobbers r0-r2
> > + * Initialize the UART. Should only be called on the boot CPU.
> > + *
> > + * Ouput:
>        ^ this should be output, and in the arm64 patch too (already committed)
Most of the arm32 code is a copy and paste from arm64 with little 
adaptation! Hence the same typo :).
I have fixed the arm32 part directly in this patch and create a new one 
for fixing the arm64 part.

> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Thank you!

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel