[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [BUG] After upgrade to Xen 4.12.0 iommu=no-igfx


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <JBeulich@xxxxxxxx>
  • Date: Thu, 1 Aug 2019 07:35:42 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QeGrWtPp+eiZAlhvLulUkQeZ4kOekC/tJRHXSnBojug=; b=K/7fG593fQSMvFzzxAjdt7chTkKXLHC5aORetSxHQA0EB36u8cgtffQf4KtiXGj2rOp6IdshdwkexKo0f+CPD5XcKfOaasLpLaO8Rs4FleuPYbzsDww+x8EwzgA306sOVqB1Q4rezfmQkRoniW2NwcZ1g9UsBReNPNqyPhzFbWoVW+bZM72KKPTRPViqGbBYuPTzCBsm6BzmPF0WDaSguL5Gfbu4RaWpehMzh16GEAvpOwWLERzqr/91c956UBH09AR0IJr8GBhUF95AEUmO6kX9YbqlO9+amOplz9ysZSihTt4uCO9gqLXAPXxM2tc+ZEUBl+ztKwSym6lzCPDWDA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZwwROogbSO5SmATXygQNOJzXL9wsKoYjdf6Q43nOGNhKQIY5HZ3IzRQ9QCmXKwyA2Jav3I/iqNBHBB7zHrkuXWfg5DflNXo6BlCjeCsh4dPRupmpzOdb7Xktq7Izn9aq7wvyBosEe8AbZizTZA2jsJ7Kb3m6IPrVg1Fe3judSwq1fmoVYV/XX8hks4EEpGRL1GT6Jc+WOktxxcsuMK3B5/cluLt7x8wSGncB/sUD069sAql5/4yu+SMDW8cFveJavCHg07xJX0p8YRxChw0jLTmcc58sb4KHgUNViA3Czg07+RKsxyXl8H/P69c77SXXjf86s6fOt/jxlaZ738AAZA==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
  • Cc: Juergen Gross <JGross@xxxxxxxx>, Roman Shaposhnik <roman@xxxxxxxxxx>, Paul Durrant <Paul.Durrant@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "boris.ostrovsky@xxxxxxxxxx" <boris.ostrovsky@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Thu, 01 Aug 2019 07:39:18 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVQGZoAIAkO6cfhESDQvB+1ma7GabWTmUwgAAaH4CAACIW8P///zuAgAAjM0D//+s8gIAAJkZwgAADUt6AAIoGGoAAAwRXgAEppbWAAVqcJ4ACQ4I9gACTsOWABkWlEIAAj2PVgAD2Ml2AAAHqUoAAtif6gAADGGaAAMXfAA==
  • Thread-topic: [Xen-devel] [BUG] After upgrade to Xen 4.12.0 iommu=no-igfx

On 31.07.2019 21:46, Andrew Cooper wrote:
> My bet is on the intel_iommu_lookup_page() call having side effects[1].
> If you take out the debugging in the middle of the loop in
> rmrr_identity_mapping(), does the problem reproduce again?

While your guess was right according to Roman's latest results, I'd
still like to note that ...

> [1] Looking at the internals of addr_to_dma_page_maddr(), it does 100%
> more memory allocation and higher-level PTE construction than looks wise
> for what is supposed to be a getter.

... there being 0 passed as last argument is supposed to suppress
any allocations (and from looking at the function I can't really
see any side effects yet in this case; all I do see is that the
first check of "alloc" could/should happen before looking up
PCI device and DRHD).

I've also double checked - there clearly is a flush after the call
to setup_hwdom_rmrr(). I'm not even convinced this flush has much
value, seeing that translation gets enabled only afterwards.

Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.