[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v8 02/16] x86/microcode: always collect_cpu_info() during boot
- To: Chao Gao <chao.gao@xxxxxxxxx>, Sergey Dyasli <sergey.dyasli@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Fri, 2 Aug 2019 13:23:02 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5q+xLRm3TlAN+fNfIJRjBfsZnKRmdnnqBzR38x7ohe4=; b=gs9zKhKORvxmY2cqIZkh4XVXxpGKmzNjAKwKB416oXGI6JmeeN7mrVkDFyYQbeG6Y7CYuwi66T0wid4hmsccTdBEGEYrCdunGUA9yEaFmIr9WgtCHCjCDXmApOcMHh0elrhns45sKZRP8EUsBlE/dxjodmQJ0/rGjPzsAb9A2s1l0eFMdNscoUSZUR8Z39Tuq5SOY3ljeirt4P8Amub2XrYsrRg56h++MCbtdJtzBl0ENhOqXDyKA20T35y5eJQS+Sp69m/Q31CaNYc+ABKKK5brTxzNGIH7nnSc4BLDNMJLrAfJJCljUcMY4L6zQSnHBRGuZh6syRRe8ws1agkzBw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a9fykoxnBFcz8F4QKt+uGO4rbRUaRpir59pLZKJzysn3//NkeWK+akBe8CUHKwonM14pOx/Y5ZbduN6dz00re4MaYvGKUhixZCAYMx9wKBrTBJI0Zff0xywJ9mfjOWBxfgGB2XD2OgynL7VlerqmcR13uxpFZXBbEZiKn6V3fINvU3+NnIFpvsVb1ZQuLtDBM9EanOj2Rg3IgPe8HRhZk1E5pu3LJ6PLAWTKvmxoJ7ccuMbYwN3WKW4E2++bsXoj2vdzKKHNyytiTLkTVkg5FCSNzxvU5eRT0pZkLglVkcq8Rmxj/bP1ka68t1srFbyEUn9Tw456c1sH6PJDedDR9A==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Ashok Raj <ashok.raj@xxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Fri, 02 Aug 2019 13:24:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVSFKO7GI4Aqr1BU6qD1RLqn3Jhqbn2igA
- Thread-topic: [PATCH v8 02/16] x86/microcode: always collect_cpu_info() during boot
On 01.08.2019 12:22, Chao Gao wrote:
> --- a/xen/arch/x86/microcode.c
> +++ b/xen/arch/x86/microcode.c
> @@ -383,10 +383,15 @@ static struct notifier_block microcode_percpu_nfb = {
>
> int __init early_microcode_update_cpu(bool start_update)
> {
> + unsigned int cpu = smp_processor_id();
> + struct ucode_cpu_info *uci = &per_cpu(ucode_cpu_info, cpu);
> int rc = 0;
> void *data = NULL;
> size_t len;
>
> + if ( !microcode_ops )
> + return -ENOSYS;
For posterity (realizing the patch has gone in already) - I'm not
convinced this should be an error condition, but the error
produced here is being ignored anyway afaics (i.e. the function
could as well return void). In no case is this an appropriate use
of ENOSYS: This isn't even on a hypercall path.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
