[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH v1] x86/spec-ctrl: Remove EAGER_FPU when PV/HVM is disabled.


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jin Nan Wang <jnwang@xxxxxxxx>
  • Date: Mon, 5 Aug 2019 08:54:08 +0000
  • Accept-language: zh-CN, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rXH1JAOG9zPlgtSUuGPSr7gLA6ZmorhCOZBaQAqrNFI=; b=fN3evQZ4Q3lZhZRwIztYgskvLXYzG37kg8iujJDy0+Nuj7iA+fMW4jNe7PV3ixjS6scllbngZAJu4O0QfZB06ODxRamQ6WAz7IIt1sMtCX2Tttce/PIeccVSwzujl61yQGyvJtvXLatkBQjBNQdGrvharvueKODa+rWDAUfrGj7Yll1KA/z+wyYHhaEkHuHkerMoGLND1Wo1cuL0gsR8bLYAxOhPPbCaUd7SQ2D+jy4nQ3li15G1lkJqkxSGx2l1BLRcqbMCAHTl+VzLewtIpkSymGLoSTfo+FiWF69mYxEPH76At/SRW1YF/LE6r6nf2TGNrGcpzNjQ95S3368QnQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O/ZOxSWVXAnBEBWnJHsR88ceuiDQmkdK3T0yPwM0ncmB3ZIFmduepgGpPQc2Wzk/0cMs8vOXmRRFl4kea0Lu6TKYdD6JYCCFFO4raqt2eey5PYvpS5/FOW+4VGLYWdQR8GgEJppo/uAwxjfsiYbbBFZF7am5kWIn8WuZGU+tNPizEJb9k/rAUImXENGOpgES3Iusl1BU3Uv2ktg7bmgCUno3qFMCOzSa5Svy/iWl1D4BEaLblAlf3pJJNICC0As9YsXyw/Qs2yfVAu2irpkeiZyXigrC1eeKu6/VS+stPRB+w5TZDCRVY/SVVW0mFxTcWy9X2O89rI27SRK10bOhiA==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=jnwang@xxxxxxxx;
  • Cc: "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, Jin Nan Wang <jnwang@xxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>
  • Delivery-date: Mon, 05 Aug 2019 08:55:22 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVS2tXqqYTwX0oZ0GkAajAz6g26Q==
  • Thread-topic: [PATCH v1] x86/spec-ctrl: Remove EAGER_FPU when PV/HVM is disabled.

In commit ac3f9a72141a48d40fabfff561d5a7dc0e1b810d:
    For one, "no-xen" should not imply "no-eager-fpu", as "eager FPU" mode
    is to guard guests, not Xen itself, which is also expressed so by
    print_details().

So when spec-ctrl=pv=off,hvm=off;  EAGER_FPU shouldn't be display in lines:
Current[Wrong]:
(XEN)   Support for HVM VMs: EAGER_FPU MD_CLEAR
(XEN)   Support for PV VMs: EAGER_FPU MD_CLEAR

expectation:
(XEN)   Support for HVM VMs: MD_CLEAR
(XEN)   Support for PV VMs: MD_CLEAR
---
 xen/arch/x86/spec_ctrl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c
index 468a847598..5f519406fb 100644
--- a/xen/arch/x86/spec_ctrl.c
+++ b/xen/arch/x86/spec_ctrl.c
@@ -128,12 +128,14 @@ static int __init parse_spec_ctrl(const char *s)
             opt_msr_sc_pv = val;
             opt_rsb_pv = val;
             opt_md_clear_pv = val;
+            opt_eager_fpu = val;
         }
         else if ( (val = parse_boolean("hvm", s, ss)) >= 0 )
         {
             opt_msr_sc_hvm = val;
             opt_rsb_hvm = val;
             opt_md_clear_hvm = val;
+            opt_eager_fpu = val;
         }
         else if ( (val = parse_boolean("msr-sc", s, ss)) >= 0 )
         {
-- 
2.22.0


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.