[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v5 02/10] AMD/IOMMU: drop stray "else"
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Woods, Brian" <Brian.Woods@xxxxxxx>
- Date: Thu, 8 Aug 2019 16:30:05 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h5q0DuNsu8Mbz5wvM5h12FKWKYqZsFHrAXtDv96m70c=; b=FytQEjfnleyljswl2xbaBIvVKHdxv2Gw9GcsomDaMJViZfxNMW7X8NryC4opv+nKWcDTeaqR4QxzG0Vx3scrUi0yTzInUf31WeT8WveX7irgaQMOycbQmOCeG0J4km9HFiw/VT9HFLq4QCnsNtcxtRVf+7EaA2RsoD5GzLdhY0fthRz+grTRUucCWOaOhFTiTvh/JTJBIizyUTh8CSgev0/R+cQuBGiNxaWG/tFWr8CC/RBuTHa1qeP1mmVZoW6WA7chDycFT7RFKMjwZKSJKKy8d3QPWKe96L6wlJ4Ox9SRShy5xcuNLHqjuV6EWwYbPaHxqHeMZB9HcM5elS7eww==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=My2YIHaiP111xafbD0uvphFMxSSTy+7jlf91qAumkTYBXIspQyoJ4GgvMqrOxxyP+D5yIsnTv4TFVro4Pq40qvqqSi9X/onu8W9Gvfol5rpeqkoPLAPrji+B9tsaJ9meZL5uMIRMIPkwH53yumFr2qyGgo6xhLHDwyO43bsmVYCnsBjDexylReqTnnrM45v15mTCtB2IlimC9kFjuELkfnwjIebmp3dC5L+NEIKWSf48FORimU0A7ALV49RRZ4SnJAf11YF3uC/ib3gQpOp/+2h3QBtb2u+IgKe2JzkvYVnfjJEQQHr9oiELN5BnqugD44wMbtKVbt3Gnu3kBFIs+g==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Brian.Woods@xxxxxxx;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Woods, Brian" <Brian.Woods@xxxxxxx>, "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Thu, 08 Aug 2019 16:30:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVTFgCXYhTGkQ9ZEGi3uYUlh/54KbxdF+A
- Thread-topic: [PATCH v5 02/10] AMD/IOMMU: drop stray "else"
On Tue, Aug 06, 2019 at 03:08:11PM +0200, Jan Beulich wrote:
> The blank line between it and the prior if() clearly indicates that this
> was meant to be a standalone if().
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Brian Woods <brian.woods@xxxxxxx>
> ---
> v5: New.
>
> --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c
> +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c
> @@ -166,8 +166,8 @@ static int __init iov_detect(void)
> if ( !iommu_enable && !iommu_intremap )
> return 0;
> - else if ( (init_done ? amd_iommu_init_interrupt()
> - : amd_iommu_init(false)) != 0 )
> + if ( (init_done ? amd_iommu_init_interrupt()
> + : amd_iommu_init(false)) != 0 )
> {
> printk("AMD-Vi: Error initialization\n");
> return -ENODEV;
>
--
Brian Woods
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
