[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V2 5/6] iommu/arm: Introduce iommu_add_dt_device API



Hi,

On 8/13/19 5:05 PM, Oleksandr wrote:
On 13.08.19 16:49, Julien Grall wrote:
On 8/2/19 5:39 PM, Oleksandr Tyshchenko wrote:
Hmm, I was thinking how to end up with only one callback re-used (add_device), really didn't want to add a new one (of_xlate). But, I didn't take into the account that this stuff is a really driver-depended. So, likely yes, we need to provide of_xlate callback.


May I ask some questions to clarify:

1. Do you want me to introduce of_xlate callback in a separate patch (under CONFIG_ARM?)?

Preferably yes. I think this wants to be under CONFIG_HAS_DEVICE_TREE rather than CONFIG_ARM.

2. Can we avoid introducing new API for that callback?

Do you mean a wrapper for the callback? If so, yes.

iommu_add_dt_device will be able to call it directly.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.