[Xen-devel] [Qemu-devel] [PATCH v7 23/42] hw/intc: Declare device little or big endian

[<tony.nguyen@xxxxxx>]

For each device declared with DEVICE_NATIVE_ENDIAN, find the set of

targets from the set of target/hw/*/device.o.

If the set of targets are all little or all big endian, re-declare

the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN

respectively.

This *naive* deduction may result in genuinely native endian devices

being incorrectly declared as little or big endian, but should not

introduce regressions for current targets.

These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it

has a new target with an opposite endian or 2) someone informed knows

better =)

Signed-off-by: Tony Nguyen <tony.nguyen@xxxxxx>

---

 hw/intc/arm_gic.c     | 12 ++++++------

 hw/intc/arm_gicv3.c   |  4 ++--

 hw/intc/etraxfs_pic.c |  2 +-

 hw/intc/imx_avic.c    |  2 +-

 hw/intc/imx_gpcv2.c   |  2 +-

 hw/intc/pl190.c       |  2 +-

 hw/intc/puv3_intc.c   |  2 +-

 7 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c

index 77427a4..283a63a 100644

--- a/hw/intc/arm_gic.c

+++ b/hw/intc/arm_gic.c

@@ -1999,38 +1999,38 @@ static const MemoryRegionOps gic_ops[2] = {

     {

         .read_with_attrs = gic_dist_read,

         .write_with_attrs = gic_dist_write,

-        .endianness = DEVICE_NATIVE_ENDIAN,

+        .endianness = DEVICE_LITTLE_ENDIAN,

     },

     {

         .read_with_attrs = gic_thiscpu_read,

         .write_with_attrs = gic_thiscpu_write,

-        .endianness = DEVICE_NATIVE_ENDIAN,

+        .endianness = DEVICE_LITTLE_ENDIAN,

     }

 };

 

 static const MemoryRegionOps gic_cpu_ops = {

     .read_with_attrs = gic_do_cpu_read,

     .write_with_attrs = gic_do_cpu_write,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_LITTLE_ENDIAN,

 };

 

 static const MemoryRegionOps gic_virt_ops[2] = {

     {

         .read_with_attrs = gic_thiscpu_hyp_read,

         .write_with_attrs = gic_thiscpu_hyp_write,

-        .endianness = DEVICE_NATIVE_ENDIAN,

+        .endianness = DEVICE_LITTLE_ENDIAN,

     },

     {

         .read_with_attrs = gic_thisvcpu_read,

         .write_with_attrs = gic_thisvcpu_write,

-        .endianness = DEVICE_NATIVE_ENDIAN,

+        .endianness = DEVICE_LITTLE_ENDIAN,

     }

 };

 

 static const MemoryRegionOps gic_viface_ops = {

     .read_with_attrs = gic_do_hyp_read,

     .write_with_attrs = gic_do_hyp_write,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_LITTLE_ENDIAN,

 };

 

 static void arm_gic_realize(DeviceState *dev, Error **errp)

diff --git a/hw/intc/arm_gicv3.c b/hw/intc/arm_gicv3.c

index 66eaa97..9b4d5ba 100644

--- a/hw/intc/arm_gicv3.c

+++ b/hw/intc/arm_gicv3.c

@@ -352,12 +352,12 @@ static const MemoryRegionOps gic_ops[] = {

     {

         .read_with_attrs = gicv3_dist_read,

         .write_with_attrs = gicv3_dist_write,

-        .endianness = DEVICE_NATIVE_ENDIAN,

+        .endianness = DEVICE_LITTLE_ENDIAN,

     },

     {

         .read_with_attrs = gicv3_redist_read,

         .write_with_attrs = gicv3_redist_write,

-        .endianness = DEVICE_NATIVE_ENDIAN,

+        .endianness = DEVICE_LITTLE_ENDIAN,

     }

 };

 

diff --git a/hw/intc/etraxfs_pic.c b/hw/intc/etraxfs_pic.c

index 20e1391..d4a27d1 100644

--- a/hw/intc/etraxfs_pic.c

+++ b/hw/intc/etraxfs_pic.c

@@ -111,7 +111,7 @@ static void pic_write(void *opaque, hwaddr addr,

 static const MemoryRegionOps pic_ops = {

     .read = pic_read,

     .write = pic_write,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_LITTLE_ENDIAN,

     .valid = {

         .min_access_size = 4,

         .max_access_size = 4

diff --git a/hw/intc/imx_avic.c b/hw/intc/imx_avic.c

index 83a4101..4bef842 100644

--- a/hw/intc/imx_avic.c

+++ b/hw/intc/imx_avic.c

@@ -308,7 +308,7 @@ static void imx_avic_write(void *opaque, hwaddr offset,

 static const MemoryRegionOps imx_avic_ops = {

     .read = imx_avic_read,

     .write = imx_avic_write,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_LITTLE_ENDIAN,

 };

 

 static void imx_avic_reset(DeviceState *dev)

diff --git a/hw/intc/imx_gpcv2.c b/hw/intc/imx_gpcv2.c

index a83333b..f37e6b5 100644

--- a/hw/intc/imx_gpcv2.c

+++ b/hw/intc/imx_gpcv2.c

@@ -64,7 +64,7 @@ static void imx_gpcv2_write(void *opaque, hwaddr offset,

 static const struct MemoryRegionOps imx_gpcv2_ops = {

     .read = imx_gpcv2_read,

     .write = imx_gpcv2_write,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_LITTLE_ENDIAN,

     .impl = {

         /*

          * Our device would not work correctly if the guest was doing

diff --git a/hw/intc/pl190.c b/hw/intc/pl190.c

index b4f31ef..e6eab1e 100644

--- a/hw/intc/pl190.c

+++ b/hw/intc/pl190.c

@@ -220,7 +220,7 @@ static void pl190_write(void *opaque, hwaddr offset,

 static const MemoryRegionOps pl190_ops = {

     .read = pl190_read,

     .write = pl190_write,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_LITTLE_ENDIAN,

 };

 

 static void pl190_reset(DeviceState *d)

diff --git a/hw/intc/puv3_intc.c b/hw/intc/puv3_intc.c

index e2f6d98..97999cc 100644

--- a/hw/intc/puv3_intc.c

+++ b/hw/intc/puv3_intc.c

@@ -100,7 +100,7 @@ static const MemoryRegionOps puv3_intc_ops = {

         .min_access_size = 4,

         .max_access_size = 4,

     },

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_LITTLE_ENDIAN,

 };

 

 static void puv3_intc_realize(DeviceState *dev, Error **errp)

-- 

1.8.3.1

​

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel