[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [Qemu-devel] [PATCH v7 24/42] hw/isa: Declare device little or big endian
- To: tony.nguyen@xxxxxx, qemu-devel@xxxxxxxxxx
- From: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
- Date: Fri, 16 Aug 2019 12:01:47 +0200
- Cc: frederic.konrad@xxxxxxxxxxx, berto@xxxxxxxxxx, qemu-block@xxxxxxxxxx, arikalo@xxxxxxxxxxxx, pasic@xxxxxxxxxxxxx, hpoussin@xxxxxxxxxxx, anthony.perard@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, balrogg@xxxxxxxxx, jasowang@xxxxxxxxxx, jiri@xxxxxxxxxxx, ehabkost@xxxxxxxxxx, b.galvani@xxxxxxxxx, eric.auger@xxxxxxxxxx, alex.williamson@xxxxxxxxxx, stefanha@xxxxxxxxxx, jsnow@xxxxxxxxxx, rth@xxxxxxxxxxx, kwolf@xxxxxxxxxx, andrew@xxxxxxxx, claudio.fontana@xxxxxxxx, crwulff@xxxxxxxxx, laurent@xxxxxxxxx, sundeep.lkml@xxxxxxxxx, michael@xxxxxxxx, qemu-ppc@xxxxxxxxxx, kbastian@xxxxxxxxxxxxxxxxxxxxx, imammedo@xxxxxxxxxx, fam@xxxxxxxxxx, peter.maydell@xxxxxxxxxx, david@xxxxxxxxxx, palmer@xxxxxxxxxx, balaton@xxxxxxxxxx, keith.busch@xxxxxxxxx, jcmvbkbc@xxxxxxxxx, hare@xxxxxxxx, sstabellini@xxxxxxxxxx, andrew.smirnov@xxxxxxxxx, deller@xxxxxx, magnus.damm@xxxxxxxxx, marcel.apfelbaum@xxxxxxxxx, atar4qemu@xxxxxxxxx, minyard@xxxxxxx, sw@xxxxxxxxxxx, yuval.shaia@xxxxxxxxxx, qemu-s390x@xxxxxxxxxx, qemu-arm@xxxxxxxxxx, jan.kiszka@xxxxxx, clg@xxxxxxxx, shorne@xxxxxxxxx, qemu-riscv@xxxxxxxxxx, i.mitsyanko@xxxxxxxxx, cohuck@xxxxxxxxxx, amarkovic@xxxxxxxxxxxx, peter.chubb@xxxxxxxxxxxx, aurelien@xxxxxxxxxxx, pburton@xxxxxxxxxxxx, sagark@xxxxxxxxxxxxxxxxx, green@xxxxxxxxxxxxxx, kraxel@xxxxxxxxxx, edgar.iglesias@xxxxxxxxx, gxt@xxxxxxxxxxxxxxx, robh@xxxxxxxxxx, borntraeger@xxxxxxxxxx, joel@xxxxxxxxx, antonynpavlov@xxxxxxxxx, chouteau@xxxxxxxxxxx, lersek@xxxxxxxxxx, Andrew.Baumann@xxxxxxxxxxxxx, mreitz@xxxxxxxxxx, walling@xxxxxxxxxxxxx, dmitry.fleytman@xxxxxxxxx, mst@xxxxxxxxxx, mark.cave-ayland@xxxxxxxxxxxx, jslaby@xxxxxxx, marex@xxxxxxx, proljc@xxxxxxxxx, marcandre.lureau@xxxxxxxxxx, alistair@xxxxxxxxxxxxx, paul.durrant@xxxxxxxxxx, david@xxxxxxxxxxxxxxxxxxxxx, xiaoguangrong.eric@xxxxxxxxx, huth@xxxxxxxxxxxxx, jcd@xxxxxxxxxxxxxxx, pbonzini@xxxxxxxxxx, stefanb@xxxxxxxxxxxxx
- Delivery-date: Fri, 16 Aug 2019 10:02:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE
On 8/16/19 9:34 AM, tony.nguyen@xxxxxx wrote:
> For each device declared with DEVICE_NATIVE_ENDIAN, find the set of
> targets from the set of target/hw/*/device.o.
>
> If the set of targets are all little or all big endian, re-declare
> the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN
> respectively.
>
> This *naive* deduction may result in genuinely native endian devices
> being incorrectly declared as little or big endian, but should not
> introduce regressions for current targets.
>
> These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it
> has a new target with an opposite endian or 2) someone informed knows
> better =)
>
> Signed-off-by: Tony Nguyen <tony.nguyen@xxxxxx>
> ---
> hw/isa/vt82c686.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
> index 12c460590..adf65d3 100644
> --- a/hw/isa/vt82c686.c
> +++ b/hw/isa/vt82c686.c
> @@ -108,7 +108,7 @@ static uint64_t superio_ioport_readb(void *opaque,
> hwaddr addr, unsigned size)
> static const MemoryRegionOps superio_ops = {
> .read = superio_ioport_readb,
> .write = superio_ioport_writeb,
> - .endianness = DEVICE_NATIVE_ENDIAN,
> + .endianness = DEVICE_LITTLE_ENDIAN,
Being ioport, one is probably OK.
> .impl = {
> .min_access_size = 1,
> .max_access_size = 1,
> --
> 1.8.3.1
>
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
