[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH lp-metadata 3/3] livepatch: Add metadata runtime retrieval mechanism
- To: Wei Liu <wl@xxxxxxx>
- From: "Wieczorkiewicz, Pawel" <wipawel@xxxxxxxxx>
- Date: Fri, 16 Aug 2019 12:54:12 +0000
- Accept-language: en-US
- Cc: Tim Deegan <tim@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxx>, "Pohlack, Martin" <mpohlack@xxxxxxxxx>, "Wieczorkiewicz, Pawel" <wipawel@xxxxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 16 Aug 2019 12:54:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVU1x89n3d35oUnkWtHe3QPQw/V6b9ugqAgAACoQA=
- Thread-topic: [PATCH lp-metadata 3/3] livepatch: Add metadata runtime retrieval mechanism
On 16. Aug 2019, at 14:44, Wei Liu < wl@xxxxxxx> wrote:
On Thu, Aug 15, 2019 at 11:27:50AM +0000, Pawel Wieczorkiewicz wrote:Extend the livepatch list operation to fetch also payloads' metadata.
This is achieved by extending the sysctl list interface with 2 extra
guest handles:
* metadata - an array of arbitrary size strings
* metadata_len - an array of metadata strings' lengths (uin32_t each)
…snip... Signed-off-by: Pawel Wieczorkiewicz <wipawel@xxxxxxxxx>
Reviewed-by: Andra-Irina Paraschiv <andraprs@xxxxxxxxxx>
Reviewed-by: Martin Pohlack <mpohlack@xxxxxxxxx>
Reviewed-by: Norbert Manthey <nmanthey@xxxxxxxxx>
---
tools/libxc/include/xenctrl.h | 22 +++++++++++----
tools/libxc/xc_misc.c | 66 +++++++++++++++++++++++++++++++++++--------
tools/misc/xen-livepatch.c | 43 ++++++++++++++++++++++------
xen/common/livepatch.c | 22 +++++++++++----
xen/include/public/sysctl.h | 19 +++++++++----
Mostly look good. One comment below...diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
index b86804b7a6..e4c8f4fe63 100644
--- a/xen/include/public/sysctl.h
+++ b/xen/include/public/sysctl.h
If it hasn't been done for this release already, changing sysctl interface requiresbumping the version number in this header.
ACK. Will do (also for earlier patches…).
Wei.
Best Regards,
Pawel Wieczorkiewicz |
Attachment:
signature.asc
Description: Message signed with OpenPGP
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Ralf Herbrich
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
