[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [qemu-s390x] [Qemu-devel] [PATCH v7 33/42] exec: Replace device_endian with MemOp
- To: Thomas Huth <thuth@xxxxxxxxxx>, tony.nguyen@xxxxxx, qemu-devel@xxxxxxxxxx
- From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
- Date: Mon, 19 Aug 2019 20:28:42 +0200
- Cc: frederic.konrad@xxxxxxxxxxx, berto@xxxxxxxxxx, qemu-block@xxxxxxxxxx, arikalo@xxxxxxxxxxxx, pasic@xxxxxxxxxxxxx, hpoussin@xxxxxxxxxxx, anthony.perard@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, philmd@xxxxxxxxxx, green@xxxxxxxxxxxxxx, jiri@xxxxxxxxxxx, ehabkost@xxxxxxxxxx, b.galvani@xxxxxxxxx, eric.auger@xxxxxxxxxx, alex.williamson@xxxxxxxxxx, stefanha@xxxxxxxxxx, jsnow@xxxxxxxxxx, rth@xxxxxxxxxxx, kwolf@xxxxxxxxxx, andrew@xxxxxxxx, claudio.fontana@xxxxxxxx, crwulff@xxxxxxxxx, laurent@xxxxxxxxx, sundeep.lkml@xxxxxxxxx, michael@xxxxxxxx, qemu-ppc@xxxxxxxxxx, kbastian@xxxxxxxxxxxxxxxxxxxxx, imammedo@xxxxxxxxxx, fam@xxxxxxxxxx, peter.maydell@xxxxxxxxxx, david@xxxxxxxxxx, palmer@xxxxxxxxxx, balaton@xxxxxxxxxx, keith.busch@xxxxxxxxx, jcmvbkbc@xxxxxxxxx, hare@xxxxxxxx, sstabellini@xxxxxxxxxx, andrew.smirnov@xxxxxxxxx, deller@xxxxxx, magnus.damm@xxxxxxxxx, marcel.apfelbaum@xxxxxxxxx, atar4qemu@xxxxxxxxx, minyard@xxxxxxx, sw@xxxxxxxxxxx, yuval.shaia@xxxxxxxxxx, qemu-s390x@xxxxxxxxxx, qemu-arm@xxxxxxxxxx, peter.chubb@xxxxxxxxxxxx, clg@xxxxxxxx, shorne@xxxxxxxxx, qemu-riscv@xxxxxxxxxx, i.mitsyanko@xxxxxxxxx, cohuck@xxxxxxxxxx, amarkovic@xxxxxxxxxxxx, jan.kiszka@xxxxxx, aurelien@xxxxxxxxxxx, pburton@xxxxxxxxxxxx, sagark@xxxxxxxxxxxxxxxxx, jasowang@xxxxxxxxxx, kraxel@xxxxxxxxxx, edgar.iglesias@xxxxxxxxx, gxt@xxxxxxxxxxxxxxx, robh@xxxxxxxxxx, lersek@xxxxxxxxxx, borntraeger@xxxxxxxxxx, joel@xxxxxxxxx, antonynpavlov@xxxxxxxxx, chouteau@xxxxxxxxxxx, balrogg@xxxxxxxxx, Andrew.Baumann@xxxxxxxxxxxxx, mreitz@xxxxxxxxxx, walling@xxxxxxxxxxxxx, dmitry.fleytman@xxxxxxxxx, mst@xxxxxxxxxx, mark.cave-ayland@xxxxxxxxxxxx, jslaby@xxxxxxx, marex@xxxxxxx, proljc@xxxxxxxxx, marcandre.lureau@xxxxxxxxxx, alistair@xxxxxxxxxxxxx, paul.durrant@xxxxxxxxxx, david@xxxxxxxxxxxxxxxxxxxxx, xiaoguangrong.eric@xxxxxxxxx, huth@xxxxxxxxxxxxx, jcd@xxxxxxxxxxxxxxx, stefanb@xxxxxxxxxxxxx
- Delivery-date: Mon, 19 Aug 2019 18:28:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Openpgp: preference=signencrypt
On 16/08/19 12:12, Thomas Huth wrote:
> This patch is *huge*, more than 800kB. It keeps being stuck in the the
> filter of the qemu-s390x list each time you send it. Please:
>
> 1) Try to break it up in more digestible pieces, e.g. change only one
> subsystem at a time (this is also better reviewable by people who are
> interested in one area)
This is not really possible, since the patch is basically a
search-and-replace. You could perhaps use some magic
("DEVICE_MEMOP_ENDIAN" or something like that) to allow a split, but it
would introduce more complication than anything else.
Agreed on the HTML though. :)
Paolo
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
