[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 2/6] xen/arm: copy dtb fragment to guest dtb



Hi,

On 19/08/2019 23:47, Stefano Stabellini wrote:
On Fri, 9 Aug 2019, Julien Grall wrote:
On 8/9/19 12:12 AM, Stefano Stabellini wrote:
It is also not entirely clear from there variable name what is the difference
between fdt and pfdt.

I have clarified and reduced the list of parameters by passing a kinfo
instead of domain and fdt separately.


Also, no more u32 in the code please. This is now part of the CODING_STYLE.

Interesting, I haven't been following. Should I use uint32_t? What's the
recommended practice for fixed sized integers now?

CODING_STYLE states:

"Use basic C types and C standard mandated typedef-s where possible (and
with preference in this order)."

So this would be uintN_t.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.