[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 3/6] remove late (on-demand) construction of IOMMU page tables
- To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 27 Aug 2019 09:45:39 +0200
- Cc: Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, "Tim \(Xen.org\)" <tim@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, JulienGrall <julien.grall@xxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, IanJackson <Ian.Jackson@xxxxxxxxxx>, VolodymyrBabchuk <Volodymyr_Babchuk@xxxxxxxx>, RogerPau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 27 Aug 2019 07:45:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.08.2019 17:41, Paul Durrant wrote:
From: Jan Beulich <jbeulich@xxxxxxxx>
Sent: 07 August 2019 11:32
On 30.07.2019 15:44, Paul Durrant wrote:
@@ -625,8 +548,7 @@ static void iommu_dump_p2m_table(unsigned char key)
ops = iommu_get_ops();
for_each_domain(d)
{
- if ( is_hardware_domain(d) ||
- dom_iommu(d)->status < IOMMU_STATUS_initialized )
+ if ( !is_iommu_enabled(d) )
continue;
Why do you drop the hwdom check here?
Because is_iommu_enabled() for the h/w domain will always be true if
iommu_enabled is true, so no need for a special case.
But the effect of the extra check was to _skip_ Dom0. If you mean to
change this, then you should say so (and why) in the description.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
