[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 5/6] iommu: tidy up iommu_us_hap_pt() and need_iommu_pt_sync() macros
- To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 27 Aug 2019 09:53:38 +0200
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, "Tim \(Xen.org\)" <tim@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, JulienGrall <julien.grall@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, IanJackson <Ian.Jackson@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 27 Aug 2019 07:53:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.08.2019 12:13, Paul Durrant wrote:
From: Jan Beulich <jbeulich@xxxxxxxx>
Sent: 07 August 2019 11:41
On 30.07.2019 15:44, Paul Durrant wrote:
Thes macros really ought to live in the common xen/iommu.h header rather
then being distributed amongst architecture specific iommu headers and
xen/sched.h. This patch moves them there.
NOTE: Disabling 'sharept' in the command line iommu options should really
be hard error on ARM (as opposed to just being ignored), so avoid
parsing that option if CONFIG_ARM is set.
Agreed. At that point the latest it would perhaps be good to have
Arm have
#define iommu_hap_pt_share true
I don't quite follow. iommu_hap_pt_share is a global bool_t defined in
passthrough/iommu.c... I'm just preventing an ARM command line from being able
to change the value... so in effect it will always be true for ARM.
The point of my comment was to allow the compiler to eliminate dead
(on Arm) code. Along the lines of Julien's subsequent replies, things
like hap_enabled() and the one here should imo be compile time
constants (rather than runtime ones) for this reason.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
