[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Partially revert "x86/mm: Clean IOMMU flags from p2m-pt code"


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>
  • Date: Wed, 28 Aug 2019 14:55:58 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bitdefender.com; dmarc=pass action=none header.from=bitdefender.com; dkim=pass header.d=bitdefender.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qwkRkVLBCfw5zxUMbosXmY43M8wm6bWOO0yPpXbqO04=; b=isr73xO1YBBCN0MvqIAR/hZjs1NLWkxs9HyDPXWOecO+fiyym3zAQb53N2/n8mUbr4RvlRWA97cCshh6HYYjdy6PixWTGux+K7Z/Uv0Mk5GIp4GlGRAzAwCDP7Ed+5QQVd6Z5GtQ/Am9CDvhmPHroWPLoyH97jD1bI4KMOo9pQZGu5YvnXyld5vIn0OjtG10IVEe4g34VPD/f9Wb1G66g8ldinxHkHGMy1bDRzucZT4S9r6FaFMp6vnc4QHewLJcgdN9+I0mu/ohmhepd2Ya0UiTghfx6OabBqmaMjh7GFhJwnUJJLy7exq8HvfEx7aPLtazxaqKwpCqnO/PA9Rq1A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V4dyI6Ajhex8atPsiCUzvrNlmUNMZI8kp7yeOKb9vbI3TFCfabpfRBPkBt1WC7QqtbesVKgbCvddLP3Qq+E6zFraCW7Bt4OEkdkPgVpJ4oOMM7C420uZju4rYgRoXeHbjn+NxLSgdQvwEBlM3fYsUi51haf77V3WRqBz/+Ubgia6qOKyRJn5hSjNl2g3FF2+j6/IRthnPfJcI3aWLzCWk4RtNrvnFYrJEgBm9OBqVSUowUDNIlxVFRQmpyos/BXOltIldIkdu+7fOLYcxgv7hmTnhxng4wRjckktoCHtZatmCbHIv3NtQ45BFG8cPiR+2+gplYvj8YfXjd4c36rCOg==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisaila@xxxxxxxxxxxxxxx;
  • Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
  • Delivery-date: Wed, 28 Aug 2019 14:56:10 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVXaVJC+w2xU9Svk+xPjPNc6UznKcQphkA
  • Thread-topic: [PATCH] Partially revert "x86/mm: Clean IOMMU flags from p2m-pt code"


On 28.08.2019 16:32, Roger Pau Monne wrote:
> This partially reverts commit
> 854a49a7486a02edae5b3e53617bace526e9c1b1 by re-adding the logic that
> propagates changes to the domain physmap done by p2m_pt_set_entry into
> the iommu page tables. Without this logic changes to the guest physmap
> are not propagated to the iommu, leaving stale iommu entries that can
> leak data, or failing to add new entries.
> 
> Note that this commit doesn't re-introduce iommu flags to the cpu page
> table entries, since the logic to add/remove entries to the iommu page
> tables is based on the p2m type and the mfn.

This sounds good but is it still safe to use the IOMMU flag space with 
another purpose?

Alex
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.