Re: [Xen-devel] [PATCH V3 8/8] iommu/arm: Add Renesas IPMMU-VMSA support

[Oleksandr <olekstysh@xxxxxxxxx>]

Hi, all


> +
> +static __init int ipmmu_init(struct dt_device_node *node, const void *data)
> +{
> +    int ret;
> +
> +    /*
> +     * Even if the device can't be initialized, we don't want to give
> +     * the IPMMU device to dom0.
> +     */
> +    dt_device_set_used_by(node, DOMID_XEN);
> +
> +    if ( !iommu_hap_pt_share )
> +    {
> +        printk_once(XENLOG_ERR "ipmmu: P2M table must always be shared between the 
> CPU and the IPMMU\n");
> +        return -EINVAL;
> +    }
> +
> +    if ( !ipmmu_stage2_supported() )
> +    {
> +        printk_once(XENLOG_ERR "ipmmu: P2M sharing is not supported in current SoC 
> revision\n");
> +        return -ENODEV;
> +    }
> +    else
> +    {
> +        /*
> +         * As 4-level translation table is not supported in IPMMU, we need
> +         * to check IPA size used for P2M table beforehand to be sure it is
> +         * 3-level and the IPMMU will be able to use it.
> +         *
> +         * TODO: First initialize the IOMMU and gather the requirements and
> +         * then initialize the P2M. In the P2M code, take into the account
> +         * the IOMMU requirements and restrict "pa_range" if necessary.
> +         */
> +        if ( IPMMU_MAX_P2M_IPA_BITS < p2m_ipa_bits )
> +        {
> +            printk_once(XENLOG_ERR "ipmmu: P2M IPA size is not supported (P2M=%u 
> IPMMU=%u)!\n",
> +                        p2m_ipa_bits, IPMMU_MAX_P2M_IPA_BITS);
> +            return -ENODEV;
> +        }

There is a patch in ML which is intended to address this TODO:

https://lists.xenproject.org/archives/html/xen-devel/2019-08/msg02237.html


--
Regards,

Oleksandr Tyshchenko


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel