Re: [Xen-devel] [PATCH v3 3/3] Add logic to use V section entry in THE REST for identifying xen trees

[Jan Beulich <jbeulich@xxxxxxxx>]

On 30.08.2019 22:09, Lars Kurth wrote:
> Specifically:
> * Move check until after the MAINTAINERS file has been read
> * Add get_xen_maintainers_file_version() for check
> * Remove top_of_tree as not needed any more
> * Faiul with extended error message when used out of tree
> 
> Signed-off-by: Lars Kurth <lars.kurth@xxxxxxxxxx>

Just a couple of nits (my Perl is far from good enough to actually
give an ack):

> @@ -311,6 +306,16 @@ while (<$maint>) {
>  }
>  close($maint);
>  
> +# Check whether we have a V entry under the REST
> +# hnd use it to get the file's version number

s/hnd/and/ 

> @@ -564,6 +569,32 @@ sub range_has_maintainer {
>      return 0;
>  }
>  
> +sub get_xen_maintainers_file_version {
> +    my $tvi = find_first_section();
> +
> +    while ($tvi < @typevalue) {
> +        my $start = find_starting_index($tvi);
> +        my $end = find_ending_index($tvi);
> +        my $i;
> +
> +        for ($i = $start; $i < $end; $i++) {
> +            my $line = $typevalue[$i];
> +         if ($line =~ m/^V:\s*(.*)/) {

A hard tab looks to have slipped in here.

> +                my $type = $1;

This variable looks to be unused, but perhaps its declaration
has some side effect?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel