Re: [Xen-devel] [PATCH v2 1/3] x86/ACPI: restore VESA mode upon resume from S3

[Jan Beulich <jbeulich@xxxxxxxx>]

On 02.09.2019 12:42, Andrew Cooper wrote:
> On 30/08/2019 14:41, Jan Beulich wrote:
>> In order for "acpi_sleep=s3_mode" to have any effect, we should record
>> the video mode we switched to during boot. Since right now there's mode
>> setting code for VESA modes only in the resume case, record the mode
>> just in that one case.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Thanks.

>> ---
>> I'm wondering actually whether the user having to explicitly request the
>> mode restoration is a good model: Why would we _not_ want to restore the
>> mode we've set during boot? In the worst case Dom0 kernel or X will
>> change the mode another time.
> 
> By this, I presume you mean drop the acpi_sleep option entirely?

Well, no, not drop it altogether. But invert the s3_mode default.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel