Re: [Xen-devel] [PATCH v2 02/11] ioreq: terminate cf8 handling at hypervisor level

[Jan Beulich <jbeulich@xxxxxxxx>]

On 04.09.2019 09:49, Roger Pau Monné  wrote:
> On Tue, Sep 03, 2019 at 06:13:59PM +0100, Andrew Cooper wrote:
>> On 03/09/2019 17:14, Roger Pau Monne wrote:
>>> diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch/x86/hvm/ioreq.c
>>> index 692b710b02..69652e1080 100644
>>> --- a/xen/arch/x86/hvm/ioreq.c
>>> +++ b/xen/arch/x86/hvm/ioreq.c
>>> @@ -1015,6 +1015,12 @@ int hvm_map_io_range_to_ioreq_server(struct domain 
>>> *d, ioservid_t id,
>>>      switch ( type )
>>>      {
>>>      case XEN_DMOP_IO_RANGE_PORT:
>>> +        rc = -EINVAL;
>>> +        /* PCI config space accesses are handled internally. */
>>> +        if ( start <= 0xcf8 + 8 && 0xcf8 <= end )
>>> +            goto out;
>>> +        else
>>> +            /* fallthrough. */
>>
>> Finally, this prohibits registering cf9 which may legitimately not be
>> terminated in Xen.
> 
> Yes, that should be cf8 - 7 not 8, thanks for catching it! Will update
> on the next version.

Well, assuming you mean + instead of - , then yes, this needs fixing.
But doing so won't take care of Andrew's comment.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel