Re: [Xen-devel] [PATCH] x86/libxl: choose a sane default for HAP

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Sep 05, 2019 at 11:40:19AM +0200, Paul Durrant wrote:
> > -----Original Message-----
> [snip]
> > -void libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
> > -                                               libxl_domain_create_info 
> > *c_info)
> > +int libxl__arch_domain_create_info_setdefault(libxl__gc *gc,
> > +                                              libxl_domain_create_info 
> > *c_info)
> >  {
> > +    libxl_physinfo pi;
> > +    int rc = libxl_get_physinfo(CTX, &pi);
> > +
> > +    if (rc) {
> > +        LOG(ERROR, "unable to get physinfo");
> > +        return rc;
> > +    }
> > +
> > +    libxl_defbool_setdefault(&c_info->hap, pi.cap_hap);
> 
> Is this going to work on ARM (where CDF_hap is required)? Because...

It should, libxl__arch_domain_create_info_setdefault for ARM sets hap
to true unconditionally.

> > +
> > +    return 0;
> >  }
> > 
> >  void libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
> > diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c
> > index c50d910a1c..74ea184087 100644
> > --- a/xen/arch/x86/sysctl.c
> > +++ b/xen/arch/x86/sysctl.c
> > @@ -165,6 +165,8 @@ void arch_do_physinfo(struct xen_sysctl_physinfo *pi)
> >          pi->capabilities |= XEN_SYSCTL_PHYSCAP_pv;
> >      if ( iommu_enabled )
> >          pi->capabilities |= XEN_SYSCTL_PHYSCAP_directio;
> > +    if ( hvm_hap_supported() )
> > +        pi->capabilities |= XEN_SYSCTL_PHYSCAP_hap;
> 
> ...this is x86-only code, and I don't see an equivalent hunk for ARM.

Yes, that flag is x86 only ATM (like all other capability flags).

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel