Re: [Xen-devel] [PATCH v8 3/6] use is_iommu_enabled() where appropriate...

[Julien Grall <julien.grall@xxxxxxx>]

Hi Paul,

On 9/2/19 3:50 PM, Paul Durrant wrote:
> ...rather than testing the global iommu_enabled flag and ops pointer.
>
> Now that there is a per-domain flag indicating whether the domain is
> permitted to use the IOMMU (which determines whether the ops pointer will
> be set), many tests of the global iommu_enabled flag and ops pointer can
> be translated into tests of the per-domain flag. Some of the other tests of
> purely the global iommu_enabled flag can also be translated into tests of
> the per-domain flag.
>
> NOTE: The comment in iommu_share_p2m_table() is also fixed; need_iommu()
>        disappeared some time ago. Also, whilst the style of the 'if' in
>        flask_iommu_resource_use_perm() is fixed, I have not translated any
>        instances of u32 into uint32_t to keep consistency. IMO such a
>        translation would be better done globally for the source module in
>        a separate patch.
>        The change to the definition of iommu_call() is to keep the PV shim
>        build happy. Without this change it will fail to compile with errors
>        of the form:
>
> iommu.c:361:32: error: unused variable ‘hd’ [-Werror=unused-variable]
>       const struct domain_iommu *hd = dom_iommu(d);
>                                       ^~
>
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> Reviewed-by: "Roger Pau Monné" <roger.pau@xxxxxxxxxx>
> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
> Acked-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel