Re: [Xen-devel] [PATCH v3] x86emul: fix test harness and fuzzer build dependencies

[Jan Beulich <jbeulich@xxxxxxxx>]

On 09.09.2019 13:01, Andrew Cooper wrote:
> On 05/09/2019 15:09, Jan Beulich wrote:
>> Commit fd35f32b4b ("tools/x86emul: Use struct cpuid_policy in the
>> userspace test harnesses") didn't account for the dependencies of
>> cpuid-autogen.h to potentially change between incremental builds. In
>> particular the harness has a "run" goal which is supposed to be usable
>> independently of the rest of the tools sub-tree building, and both the
>> harness and the fuzzer code are also supposed to be buildable
>> independently. Therefore a re-build of the generated header needs to be
>> triggered first, which is achieved by introducing a new top-level target
>> pattern (for just the "run" part for now).
>>
>> Further cpuid.o did not have any dependencies added for it.
>>
>> Finally, while at it, add a "run" target to the cpu-policy test harness.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Thanks.

>> ---
>> TBD: Something similar would be nice for building both tools/tests/*/
>>      and tools/fuzz/*/, but I'm uncertain whether respective top level
>>      targets build-tests-% and build-fuzz-% would be welcome.
> 
> Fuzz targets are much more complicated to set up and run correctly.  I'd
> skip them for now.

Well, building shouldn't be that difficult - one only needs to set the
compiler etc correctly iirc. Running is less straightforward, which is
why I've mentioned only the build part.

Independent of the fuzzer aspect, what about a special top level build
target for the test harnesses (alongside the run one introduced here)?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel