Re: [Xen-devel] [PATCH v2 20/48] xen: let vcpu_create() select processor

[Jan Beulich <jbeulich@xxxxxxxx>]

On 09.08.2019 16:58, Juergen Gross wrote:
> --- a/xen/common/schedule.c
> +++ b/xen/common/schedule.c
> @@ -368,14 +368,52 @@ static struct sched_unit *sched_alloc_unit(struct vcpu 
> *v)
>      return NULL;
>  }
>  
> -int sched_init_vcpu(struct vcpu *v, unsigned int processor)
> +static unsigned int sched_select_initial_cpu(const struct vcpu *v)

Given the response on an earlier similar question, I don't suppose
I could talk you into dropping the sched_ prefix here?

> --- a/xen/include/xen/sched-if.h
> +++ b/xen/include/xen/sched-if.h
> @@ -457,7 +457,7 @@ struct cpupool
>  #define cpupool_online_cpumask(_pool) \
>      (((_pool) == NULL) ? &cpu_online_map : (_pool)->cpu_valid)
>  
> -static inline cpumask_t* cpupool_domain_cpumask(struct domain *d)
> +static inline cpumask_t* cpupool_domain_cpumask(const struct domain *d)

It would certainly be nice to correct the misplace * here at the
same time (which clearly could be done while committing, if
everything up to here was ready to go in).

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel