[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v9] x86/emulate: Send vm_event from emulate
- To: Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Razvan COJOCARU <rcojocaru@xxxxxxxxxxxxxxx>, "tamas@xxxxxxxxxxxxx" <tamas@xxxxxxxxxxxxx>
- From: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxxxxxx>
- Date: Wed, 11 Sep 2019 11:21:25 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bitdefender.com; dmarc=pass action=none header.from=bbu.bitdefender.biz; dkim=pass header.d=bbu.bitdefender.biz; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uyiKVO1t+nbU+3V0LyIxclkdbW4B0+b3OKXXayl8ILU=; b=Mw4gAEvp6M/tRqFLWKvkfRLlLr7kdEQsmTuYwPxrTJnrGhna/EGgJwt+u7rhTgVoV0el6q45nbbk3Ia9tgi1G0eZmGTYXrJITYoSGkA1CXMM0SGenzZkp5LNy/z+zDnRSL5ZmiV7OEa/dZt/0xnbAK7tDE2SmsXfdfesJog9D8vjcDetNTUXqhZjFts+o4Bw/ZZcMU1MxIrncuI7CbHB35b8GxKXSAIFvluOkZ5JXmoi4sxsPIr5t5rRK21Ouys0rbDzaGrrpGKvEsizoasGU5445B3DMqe74JIsYZVI4TmYuu7ulg2xaJ/rUE9/Au+HwZjgkaROcUzslvPqlVUCiA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j4QSFYEqALFBvoOAp6ci6DlGmITDwebQ7MU2fXwhMSc//xkcnHlpaCHX5b0YU51kBOHyMaJ1w/eqkk7vH1xa7/51KXzfe8QV2GBcebEYLNewYs6lGf2Q+44+HNUk75ypGLFxEBA+0C7TnNEU0qBeszJ4ZIUMZZ2hgKOCgmChDpl6hSjecgjrQuFx6wS7DkLMLnG6Qi1hJGk16YgZSGCUEHPmevRaptKstk35DOnhQe3gVXROIBYEZCv8txWDKcoiP9F4rTsNr4kPqc6and5FDIK+IHUcDBLT0wXBdNax7Sn/r9pGaZSKxG2PrUam1iybLFCYMc6Yydh2epTbkQl7yg==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=rcojocaru@xxxxxxxxxxxxxxx;
- Cc: Petre Ovidiu PIRCALABU <ppircalabu@xxxxxxxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, "george.dunlap@xxxxxxxxxxxxx" <george.dunlap@xxxxxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "paul.durrant@xxxxxxxxxx" <paul.durrant@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 11 Sep 2019 11:25:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVZyQz09ftstBAgkqLCbI9BLbek6cmQG2AgAALiACAAAvWgA==
- Thread-topic: [PATCH v9] x86/emulate: Send vm_event from emulate
On 9/11/19 1:39 PM, Alexandru Stefan ISAILA wrote:
>
>
> On 11.09.2019 12:57, Jan Beulich wrote:
>> On 09.09.2019 17:35, Alexandru Stefan ISAILA wrote:
>>> +/*
>>> + * Send memory access vm_events based on pfec. Returns true if the event
>>> was
>>> + * sent and false for p2m_get_mem_access() error, no violation and event
>>> send
>>> + * error. Assumes the caller will check arch.vm_event->send_event.
>>> + *
>>> + * NOTE: p2m_get_mem_access() can fail if the entry was not found in the
>>> EPT
>>> + * (in which case access to it is unrestricted, so no violations can
>>> occur).
>>> + * In this cases it is fine to continue the emulation.
>>> + */
>>> +bool hvm_monitor_check_ept(unsigned long gla, gfn_t gfn, uint32_t pfec,
>>> + uint16_t kind)
>>
>> Why did you choose to have "ept" in the name and also mention it
>> in the commit? Is there anything in here which isn't generic p2m?
>
> The name was suggested by Razvan Cojocaru. I have no preference in the
> name. Maybe Tamas can suggest a good one.
I've suggested "ept" in the name because "regular" emulation ignores it,
and this function takes it into account, hence the "check_ept" (which I
thought would be read together). It's fine to change it to something else.
Thanks,
Razvan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
