Re: [Xen-devel] [PATCH v10 03/16] microcode: introduce a global cache of ucode patch

[Jan Beulich <jbeulich@xxxxxxxx>]

On 12.09.2019 09:22, Chao Gao wrote:
> --- a/xen/arch/x86/microcode_intel.c
> +++ b/xen/arch/x86/microcode_intel.c
> @@ -260,6 +260,36 @@ static enum microcode_match_result 
> microcode_update_match(
>      return MIS_UCODE;
>  }
>  
> +static bool match_cpu(const struct microcode_patch *patch)
> +{
> +    if ( !patch )
> +        return false;
> +
> +    return microcode_update_match(&patch->mc_intel->hdr,
> +                                  smp_processor_id()) == NEW_UCODE;
> +}
> +
> +static void free_patch(void *mc)
> +{
> +    xfree(mc);
> +}
> +
> +static enum microcode_match_result compare_patch(
> +    const struct microcode_patch *new, const struct microcode_patch *old)
> +{
> +    /*
> +     * Both patches to compare are supposed to be applicable to local CPU.
> +     * Just compare the revision number.
> +     */
> +    ASSERT(microcode_update_match(&old->mc_intel->hdr, smp_processor_id()) !=
> +               MIS_UCODE);
> +    ASSERT(microcode_update_match(&new->mc_intel->hdr, smp_processor_id()) !=
> +               MIS_UCODE);

With the indentation here fixed
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel