Re: [Xen-devel] [PATCH v2 26/48] xen/sched: rework and rename vcpu_force_reschedule()

[Jan Beulich <jbeulich@xxxxxxxx>]

On 13.09.2019 11:33, Juergen Gross wrote:
> On 10.09.19 16:06, Jan Beulich wrote:
>> On 09.08.2019 16:58, Juergen Gross wrote:
>>> vcpu_force_reschedule() is only used for modifying the periodic timer
>>> of a vcpu.
>>
>> I don't think this is true prior to this patch, or else ...
>>
>>> @@ -419,8 +419,6 @@ int pv_shim_shutdown(uint8_t reason)
>>>   
>>>           if ( v != current )
>>>               vcpu_unpause_by_systemcontroller(v);
>>> -        else
>>> -            vcpu_force_reschedule(v);
>>
>> ... there wouldn't be this deletion of code. Without further
>> explanation it's unclear to me whether the re-schedule here
>> isn't also needed for other than processing the reset of the
>> periodic timer period.
> 
> This deletion is related to replacing the direct write of
> v->periodic_period by vcpu_set_periodic_timer().
> 
> I can't see any other reason for the re-schedule.

Roger, you added this in e89cb79aae ("xen/pvshim: add migration
support") - can you confirm the above?

Thanks, Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel