Re: [Xen-devel] [PATCH v2 30/48] xen/sched: introduce unit_runnable_state()

[Jan Beulich <jbeulich@xxxxxxxx>]

On 13.09.2019 16:07, Juergen Gross wrote:
> On 11.09.19 12:30, Jan Beulich wrote:
>> On 09.08.2019 16:58, Juergen Gross wrote:
>>> --- a/xen/include/xen/sched.h
>>> +++ b/xen/include/xen/sched.h
>>> @@ -174,6 +174,7 @@ struct vcpu
>>>           XEN_GUEST_HANDLE(vcpu_runstate_info_compat_t) compat;
>>>       } runstate_guest; /* guest address */
>>>   #endif
>>> +    int              new_state;
>>
>> I realize its counterpart (wrongly) is plain int in the public
>> interface - I think it should be unsigned int here and uint32_t
>> there. I'm pondering whether to do a swipe across all public
>> headers to replace all uses of plain int (and alike) with
>> fixed width types.
> 
> The list for cleanups is becoming longer...
> 
> So are you fine with me not changing anything in this regard right now?

Well, it wouldn't be bad if the new field was of appropriate type.
But given the state of things elsewhere I wouldn't insist.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel