Re: [Xen-devel] [PATCH] x86/viridian: Reword HV_X64_MSR_CRASH_CTL print message

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
> Sent: 16 September 2019 13:48
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>; Xen-devel 
> <xen-devel@xxxxxxxxxxxxxxxxxxxx>
> Cc: Jan Beulich <JBeulich@xxxxxxxx>; Wei Liu <wl@xxxxxxx>; Roger Pau Monne 
> <roger.pau@xxxxxxxxxx>
> Subject: Re: [PATCH] x86/viridian: Reword HV_X64_MSR_CRASH_CTL print message
> 
> On 15/09/2019 12:51, Paul Durrant wrote:
> >> -----Original Message-----
> >> From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> >> Sent: 13 September 2019 17:04
> >> To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
> >> Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>; Jan Beulich 
> >> <JBeulich@xxxxxxxx>; Wei Liu
> <wl@xxxxxxx>;
> >> Roger Pau Monne <roger.pau@xxxxxxxxxx>; Paul Durrant 
> >> <Paul.Durrant@xxxxxxxxxx>
> >> Subject: [PATCH] x86/viridian: Reword HV_X64_MSR_CRASH_CTL print message
> >>
> >> Message such as:
> >>
> >>   (XEN) d3v0 VIRIDIAN CRASH: 51 1 ffff9700e146b000 1000 204
> >>
> >> have confused many people into thinking the the problem is a bug in the
> >> viridian code.  The prefix was intended to signify the use of the viridian
> >> crash-reporting interface.
> >>
> >> Replace the VIRIDIAN prefix with 'reported' to reduce the confusion to
> >> non-xen-developers trying to interpret the message.
> > This is a message that is peculiar to Windows VMs, so how about "Windows VM 
> > CRASH"?
> 
> I presume you mean particular, but no - it isn't windows which is the
> exclusive user of this interface.  Linux has a driver to use it when
> running under HyperV.

Hmm, that's a bit odd. I thought the crash codes are Windows specific. Perhaps 
they can be distinguished in some way. All the same, the log line needs to lead 
people to some way of decoding the magic numbers I think. How about:

"VIRIDIAN REPORTED CRASH"

?

  Paul

> 
> ~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel