Re: [Xen-devel] [PATCH v3 10/12] livepatch: Handle arbitrary size names with the list operation

[Jan Beulich <jbeulich@xxxxxxxx>]

On 16.09.2019 12:59, Pawel Wieczorkiewicz wrote:
> @@ -951,11 +952,13 @@ struct xen_sysctl_livepatch_list {
>                                                 amount of payloads and 
> version.
>                                                 OUT: How many payloads left. 
> */
>      uint32_t pad;                           /* IN: Must be zero. */
> +    uint64_t name_total_size;               /* OUT: Total size of all 
> transfer names */

Why uint64_t and not uint32_t? You don't expect this to grow
beyond 4GiB, do you?

And why OUT rather than IN/OUT? Once you make this "arbitrary
size", I don't see a need for limiting this to ...

>      XEN_GUEST_HANDLE_64(xen_livepatch_status_t) status;  /* OUT. Must have 
> enough
>                                                 space allocate for nr of 
> them. */
>      XEN_GUEST_HANDLE_64(char) name;         /* OUT: Array of names. Each 
> member
> -                                               MUST XEN_LIVEPATCH_NAME_SIZE 
> in size.
> -                                               Must have nr of them. */
> +                                               may have an arbitrary length 
> up to
> +                                               XEN_LIVEPATCH_NAME_SIZE 
> bytes. Must have
> +                                               nr of them. */

... XEN_LIVEPATCH_NAME_SIZE bytes per entry.

And finally - please send to the list just once, i.e. please
don't have two xen-devel@ in the recipients list.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel