[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v10] x86/emulate: Send vm_event from emulate


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>
  • Date: Tue, 17 Sep 2019 15:39:12 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bitdefender.com; dmarc=pass action=none header.from=bitdefender.com; dkim=pass header.d=bitdefender.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MAyzpw+sgphUgb2993Z5tkIwNVouyyz03cfjX4NJPMg=; b=LIeTmBFdSLBj/anXOBdmeI/lwycI+5NJvoKItEKpZeFZgQH7pT5dQBL7qhOWeE8z2tHmsGK+3paq87zwcKiAbO9xsAt5UyVTjHuG0rtBGI+su7SHF/PHxH6UuA++3ncukCuvv/CAzHtwvUzRnA0HsIt6zUCRKXjOA7VE1L4L6PDVlAAHRrPDHpG1l8Tr2WowfZ4oVLIeir/dddDKs5e0k5pioQKucjkUzFAxEt7qELyo1jFtxvQLQ8n4qqY//qpnl96/jiqEFi+TnL8ll1UbZu1F4rrVQ9elG30FV83IvrSsajfvqPdHVMpWjydMTWsBUgZU6VTU81H73qc//alMqA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VO2KCvBidZlGjrbtb1s1i35Quk0XhaRNktMSNJ2QhxYhZyDwz81fRNAqcDhJJsDJ9YdfV+ce+5GidbTd35mUEKO5ATvAcJgGJ//I/VvvgdVT/5mqQbJEQEHIasQgo4luuahB311wlPWK47RW5mJAIr9KLCzlySxP5Cr/F/GvtuuFzTu7yKCKttmbRF44axOiTXL5X+1u05sC87nG+ihipDMPZDXRAmKi2Uahh1UYT9J+PuhDLVBbCDu/kzMViH/7gfebBNPBVEs8DNW3cKKqA1Ym08FWELE9H8BJ2qaist4Vxx3hH5TFgvARTRnqStChJLGsvq8ZcBETsbhIPmYkYQ==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisaila@xxxxxxxxxxxxxxx;
  • Cc: Petre Ovidiu PIRCALABU <ppircalabu@xxxxxxxxxxxxxxx>, "tamas@xxxxxxxxxxxxx" <tamas@xxxxxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, Razvan COJOCARU <rcojocaru@xxxxxxxxxxxxxxx>, "george.dunlap@xxxxxxxxxxxxx" <george.dunlap@xxxxxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "paul.durrant@xxxxxxxxxx" <paul.durrant@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 17 Sep 2019 15:39:31 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVbGY5LYraxeTPu06yM6Qe3Haip6cudlQAgAEKjgCAAATfAIAAl0IA///TxQCAADniAP//zwuAgAAJlwA=
  • Thread-topic: [Xen-devel] [PATCH v10] x86/emulate: Send vm_event from emulate


On 17.09.2019 18:04, Jan Beulich wrote:
> On 17.09.2019 17:00, Alexandru Stefan ISAILA wrote:
>> There is no problem, I understand the risk of having suspicious return
>> values. I am not hanged on having this return. I used this to skip
>> adding a new return value. I can do this if we agree on a suitable name
>> for a new return value in enum hvm_translation_result. I can propose
>> HVMTRANS_bad_gfn_access.
> 
> How intrusive would such a change be?
> 

Only the return for hvm_copy_to_guest_linear() and 
hvm_copy_from_guest_linear() will be affected.
There are 2 places to add checks, in linear_write() and linear_read().
The new return value can turn up only in hvm_emulate_one_vm_event() 
context, when vm_event->send_event flag is true.

Alex
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.