[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 23/35] libxl: libxl__initiate_device_usbdev_remove now use ev_qmp



Anthony PERARD writes ("[PATCH 23/35] libxl: 
libxl__initiate_device_usbdev_remove now use ev_qmp"):
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
...
>      libxl_device_usbctrl usbctrl;
> +    bool has_callback = false;

Not sure I like this encoding of program flow in a variable but it
seems correct, and it's a matter of taste, so:

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

(And I'm not sure I have a better suggestion.)

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.