[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 3/9] x86/mm: honor opt_pcid also for 32-bit PV domains



On 17.09.2019 21:00, Andrew Cooper wrote:
> On 17/09/2019 07:14, Jan Beulich wrote:
>> I can't see any technical or performance reason why we should treat
>> 32-bit PV different from 64-bit PV in this regard.
> 
> Well, other than the fact this setting is only read for a 64bit guest...

How come? make_cr3() uses it uniformly, as does pv_make_cr4().
toggle_guest_mode() is the one case where it's strictly 64-bit
guest only.

> The reason it isn't set for 32bit guests is that there is no scenario
> where we use it.

"pcid=1" and "pcid=noxpti" both are scenarios where, with this
patch in place, we would use it.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.