[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] create-diff-object: more precisely identify .rodata sections



Hi,

On 18/09/2019 10:52, Wieczorkiewicz, Pawel wrote:


On 18. Sep 2019, at 11:49, Jan Beulich <jbeulich@xxxxxxxx> wrote:

On 18.09.2019 09:35, Pawel Wieczorkiewicz wrote:
This is needed for more precise patchability verification.
Only non-special .rodata sections should be subject
for such a non-referenced check in kpatch_verify_patchability().
Current check (non-standard, non-rela, non-debug) is too weak and
allows also non-rodata sections without referenced symbols to slip
through.

Detect .rodata section by checking section's type (SHT_PROGBITS),
flags (no exec, no write) and finally name prefix.

Signed-off-by: Pawel Wieczorkiewicz <wipawel@xxxxxxxxx>
Reviewed-by: Andra-Irina Paraschiv <andraprs@xxxxxxxxxx>
Reviewed-by: Bjoern Doebel <doebel@xxxxxxxxx>
Reviewed-by: Norbert Manthey <nmanthey@xxxxxxxxx>
---
common.c             |  7 +++++++
common.h             |  1 +
create-diff-object.c | 13 ++++++-------
3 files changed, 14 insertions(+), 7 deletions(-)

Seeing that I have been Cc-ed here - what tree is this against? I
don't recognize the file names as anything I'm a maintainer for.

Jan

You have been probably added because I have used the following command:

$ scripts/./add_maintainers.pl -d ~/git/livepatch-build-tools

'-d' only tells you where the patches files are. The script will look up for the MAINTAINERS file in the current directory.

From you command line, it would be xen.git. So it is not normal the wrong maintainers are CCed.

What you want is:

42sh> cd livepatch-build-tools
42sh> ../xen/scripts/add_maintainers.pl -d .

Note that you would need the patch [1] in order to get the script working.

Cheers,

[1] https://lists.xenproject.org/archives/html/xen-devel/2019-09/msg01139.html

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.