Re: [Xen-devel] [PATCH 08/35] libxl: Replace libxl__qmp_initializations by ev_qmp calls

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Tue, Sep 17, 2019 at 06:02:18PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[PATCH 08/35] libxl: Replace 
> libxl__qmp_initializations by ev_qmp calls"):
> > Setup a timeout of 10s for all the commands. It used to be about 5s
> > per commands.
> 
> This patch is quite hard to review because it is a
> rewrite/rearrangement and I can't see where all the pieces come from.
> 
> How hard would it be to make a pre-patch to shuffle the code to the
> same place as it's going, and change the variable names etc. ?

It is actually not that easy to pre-move the functions to the new place,
those functions access the struct `qmp', but the detail of the struct is
only available in libxl_qmp.c. Those functions also calls
qmp_synchronous_send(), but that can easy been worked around.

Would a series of patch which would needs to be squashed together after
review would be enough? Otherwise, I don't see how I can do it without
breaking bisectability.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel