[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v11] x86/emulate: Send vm_event from emulate
- To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>
- Date: Fri, 20 Sep 2019 08:10:37 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bitdefender.com; dmarc=pass action=none header.from=bitdefender.com; dkim=pass header.d=bitdefender.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7zvCm5f1eG+9IFPr00XNzDPlF1AgaIWqvgyPA+Q8Z3g=; b=aZ05Yi2UZXaVvdhVxq3J+nB4aFSvZTSliYeHhmfrqUZmfZXmy91V7TGOuf5jSiMM7Seb1SEt9QMVe3I1I8KJIupd76Cj9XRDK5JBrzbZz5G6Smt9eWtNB9P5tgmx1DP1+JgekKQKyWsjICt4KvTRDXfZV/Z/j4ktMR5UvF9cT0dA8f8RrcRXtoovzDNFnqPaOiAY1RXS4czFllVSrP9uYZYXrSGZTeJq1oZ3Juyi8LC8hBcIYhBSGAsKKJfNRd2dvuWGs6tEXQMja+RlLwAfedcBzLSUWdH4nf7BJSZXav2gruRGBoIJKvBcm8t1AeifFNBXaj3Ar/7AemWRmSP3gg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e9FGvEUYtKTiBFT7dYUgH+Ag5RNiwpYZAobJCv4siHqP6Pz94ZO3DsXEemNNfDey1k00NfrvHAd7gcJ1U5GfasY67C/YGWr52d9MIhc47IiEcHn6/phEMDqPjspOQcWslF6TXKMYSIZaj/BNxqT5BkzCtoNx+JZF7FsjyGBULaHwxozZk96DJtNXr10wjV9tW8/mFFaBmcjJNECVp0/Pp1jNLkZEEBq0UytRguwirH9IVHxgXJJBF0JzoULXXQQhpkmfHFZhzaFNiUXzUdE2Q8uWjMeK45E/IATltgfOMWD/OYF77ZI/FiKLoGbx6UGpzSUIj1vUzNZMXviW+bLR3Q==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisaila@xxxxxxxxxxxxxxx;
- Cc: Petre Ovidiu PIRCALABU <ppircalabu@xxxxxxxxxxxxxxx>, "tamas@xxxxxxxxxxxxx" <tamas@xxxxxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, Razvan COJOCARU <rcojocaru@xxxxxxxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Fri, 20 Sep 2019 08:10:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVbuqvObi2c4eeME6qC/Xll4ji7KczB5JAgAEwWQA=
- Thread-topic: [PATCH v11] x86/emulate: Send vm_event from emulate
On 19.09.2019 17:09, Paul Durrant wrote:
>> -----Original Message-----
>> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
>> index fdb1e17f59..4cc077bb3f 100644
>> --- a/xen/arch/x86/hvm/hvm.c
>> +++ b/xen/arch/x86/hvm/hvm.c
>> @@ -3236,6 +3236,19 @@ static enum hvm_translation_result __hvm_copy(
>> return HVMTRANS_bad_gfn_to_mfn;
>> }
>>
>> + /*
>> + * In case a vm event was sent return paged_out so the emulation
>> will
>> + * stop with no side effect
>> + */
>> + if ( (flags & HVMCOPY_linear) &&
>> + unlikely(v->arch.vm_event) &&
>> + v->arch.vm_event->send_event &&
>> + hvm_monitor_check_p2m(addr, gfn, pfec, npfec_kind_with_gla) )
>> + {
>> + put_page(page);
>> + return HVMTRANS_bad_gfn_access;
>
> This doesn't match the comment above. Did you mean to return
> HVMTRANS_gfn_paged_out? I'm guessing not, in which case the comment needs to
> be fixed.
Yes, it seems I missed that but given that the return name will change I
will have the comment fixed in the next version. Thanks for pointing
this out.
Alex
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
