Re: [Xen-devel] [PATCH] tools/ocaml: Build fix following libxl API changes

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Anthony PERARD writes ("Re: [PATCH] tools/ocaml: Build fix following libxl API 
changes"):
> On Fri, Sep 20, 2019 at 05:19:02PM +0100, Anthony PERARD wrote:
> > The following libxl API became asynchronous and gained an additional
> > `ao_how' parameter:
> >     libxl_domain_pause()
> >     libxl_domain_unpause()
> >     libxl_send_trigger()
> > 
> > Adapt the ocaml binding.
> > 
> > Build tested only.
> > 
> > Fixes: edaa631ddcee665cdfae1cf6bc7492c791e01ef4
> > Fixes: 95627b87c3159928458ee586e8c5c593bdd248d8
> > Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> > ---
> > 
> > Notes:
> >     Currently, all libxl API that takes an `ao_how` have `?async:'a -> unit`
> >     in the ocaml definition (and an extra unused value unit in the c stub
> >     file), is that `unit` needed ?
> >     
> >     I tried to add it, but then for stub_xl_send_trigger() I had to use
> >     CAMLparam6, and that doesn't exist.
> 
> I discovered CAMLxparam1 macro, but that's not better:
>     File "xenlight.ml", line 1735, characters 25-84:
>     Error: An external function with more than 5 arguments requires a second 
> stub function
>            for native-code compilation

In order to unbreak the build I have acked and pushed this patch right
away, but IMO a review from an ocaml maintainer is quite important
here.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel