[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 13/47] xen/sched: add is_running indicator to struct sched_unit

On 19.09.19 17:53, Jan Beulich wrote:
On 14.09.2019 10:52, Juergen Gross wrote:
@@ -1673,8 +1676,10 @@ static void schedule(void)
       * switch, else lost_records resume will not work properly.
- ASSERT(!next->is_running);
+    ASSERT(!next->sched_unit->is_running);
      next->is_running = 1;
+    next->sched_unit->is_running = 1;

Nit: The new field is of type bool, and hence you should write true
and false into it. This may look odd next to the 1 above, but by
the end of the series the two won't sit next to each other anymore.

Indeed. And making vcpu->is_running a bool is another item on my list
for the cleanup.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.